Feature/lookup let #913
Merged
Feature/lookup let #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mongomock/aggregate.py # tests/test__collection_api.py
…he errors string. Check for partial error string match in the test_insert_bson_validation test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff
8000
@@
## develop #913 +/- ##
===========================================
+ Coverage 96.06% 96.07% +0.01%
===========================================
Files 35 35
Lines 10084 10118 +34
===========================================
+ Hits 9687 9721 +34
Misses 397 397 ☔ View full report in Codecov by Sentry. |
|
@mdomke this PR was merged 4 months ago. any change to cut a release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support pipeline and let in the $lookup aggregation.
Most of the work was done by @pcorpet in the feature/lookup-let (401210a) branch. Merged this into develop and added support for the concise syntax.
This should solve issues #845 and #536.