Simplify internal implementation details of EndsWith
#1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 93.23% 93.22% -0.01%
==========================================
Files 112 112
Lines 3400 3395 -5
Branches 962 960 -2
==========================================
- Hits 3170 3165 -5
Misses 214 214
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR simplifies the implementation of
EndsWithin the following ways:Impl) to be non-static so its signature can be simpler (it doesn't induce a closure).Allby usingSequenceEqualinstead.comparerinitialization, which can be passed as-is toSequenceEqual.