8000 Fix `Subsets` so it returns an empty set when k = 0 by Orace · Pull Request #646 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Subsets so it returns an empty set when k = 0 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2023
Merged

Fix Subsets so it returns an empty set when k = 0 #646

merged 6 commits into from
Oct 21, 2023

Conversation

Orace
Copy link
Contributor
@Orace Orace commented Nov 5, 2019 •
edited
Loading

This PR addresses #645

8000
@Orace Orace changed the title Fix #645 Fix bug in KSubset with k = 0 Nov 5, 2019
Crossbow78
Crossbow78 reviewed Dec 5, 2019
View reviewed changes
atifaziz
atifaziz requested changes Dec 27, 2019
View reviewed changes
Copy link
Member
@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. I've done an initial review that requires some changes.

8000
@codecov
Copy link
codecov bot commented Dec 27, 2019 •
edited
Loading

Codecov Report

Merging #646 (43a9565) into master (189a054) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 43a9565 differs from pull request most recent head 4341b59. Consider uploading reports for the commit 4341b59 to get more accurate results

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   92.57%   92.63%   +0.05%     
==========================================
  Files         113      113              
  Lines        3422     3422              
  Branches     1055     1056       +1     
==========================================
+ Hits         3168     3170       +2     
+ Misses        191      189       -2     
  Partials       63       63
Files Coverage Δ
MoreLinq/Subsets.cs 96.47% <100.00%> (+2.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz changed the title Fix bug in KSubset with k = 0 Fix Subsets so it returns an empty set when k = 0 Dec 30, 2019
@atifaziz atifaziz changed the title Fix Subsets so it returns an empty set when k = 0 Fix Subsets so it returns an empty set when k = 0 Oct 20, 2023
@atifaziz atifaziz linked an issue Oct 20, 2023 that may be closed by this pull request
Subsets(0) should return an empty set #645
Closed
@atifaziz atifaziz merged commit 7d438ed into morelinq:master Oct 21, 2023
julienasp pushed a commit to julienasp/MoreLINQ that referenced this pull request Nov 14, 2023
@Orace @atifaziz @julienasp
Fix "Subsets" to return an empty set when k = 0
d1a94ca 
This is a squashed merge of PR morelinq#646 that fixes morelinq#645.

---------

Co-authored-by: Atif Aziz <code@raboof.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crossbow78 Crossbow78 Crossbow78 left review comments

@atifaziz atifaziz atifaziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsets(0) should return an empty set
3 participants
@Orace @atifaziz @Crossbow78
0