8000 Fix "GroupAdjacent" null key handling bug by atifaziz · Pull Request #810 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix "GroupAdjacent" null key handling bug #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

Fix "GroupAdjacent" null key handling bug #810

merged 1 commit into from
Mar 23, 2021

Conversation

atifaziz
Copy link
Member

This PR fixes the issue reported in #809.

@atifaziz atifaziz linked an issue Mar 23, 2021 that may be closed by this pull request
GroupAdjacent no longer works for null keys #809
Closed
viceroypenguin
viceroypenguin approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor
@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you do a follow up to check every place that {} x is being used to ensure valid usage?

@atifaziz
Copy link
Member Author

Should you do a follow up to check every place that {} x is being used to ensure valid usage?

That's the idea with #803 since it's not just about the type annotations in the public surface, but also within the body of the implementation. Unfortunately, not having a test previously for when a key is null means a regression could have been introduced with any refactoring, such as was done with #582.

@atifaziz atifaziz merged commit 657e327 into morelinq:master Mar 23, 2021
@atifaziz atifaziz deleted the fix/G 6C58 roupAdjacent-null-keys branch March 23, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GroupAdjacent no longer works for null keys
2 participants
@atifaziz @viceroypenguin
0