Fix Flatten signature parts to be null-oblivious
#847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 108 108
Lines 3472 3472
Branches 1032 1032
=======================================
Hits 3196 3196
Misses 213 213
Partials 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Nov 7, 2022
Sign up for free
to join this conversation on G
598F
itHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to #803. If fixes parts of
Flattento be null-oblivious. SinceIEnumerator.Currentis null-oblivious, the right call here seems to be to mark theobjectparameter ofIEnumerable<>andFunc<,>to be null-oblivious too (rather thanobject?).