8000 Make `ToDataTable` implementation null-safer by atifaziz · Pull Request #854 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make ToDataTable implementation null-safer #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atifaziz
Copy link
Member

Expression property of System.Linq.Expressions.MemberExpression is defined to be nullable. This PR ensures that the property is always access in a null-safe manner; in other words only when it's not null.

@atifaziz atifaziz self-assigned this Oct 24, 2022
@codecov
Copy link
codecov bot commented Oct 24, 2022

Codecov Report

Merging #854 (dc0a216) into master (212be62) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   92.05%   92.04%   -0.01%     
==========================================
  Files         108      108              
  Lines        3472     3471       -1     
  Branches     1032     1032              
==========================================
- Hits         3196     3195       -1     
  Misses        213      213              
  Partials       63       63              
Impacted Files Coverage Δ
MoreLinq/ToDataTable.cs 96.87% <100.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz
Copy link
Member Author
atifaziz commented Nov 3, 2022

This was superseded by PR #860.

@atifaziz atifaziz closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0