8000 Fix code coverage using latest coverlet collector by atifaziz · Pull Request #858 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix code coverage using latest coverlet collector #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Fix code coverage using latest coverlet collector #858

merged 1 commit into from
Oct 30, 2022

Conversation

atifaziz
Copy link
Member
@atifaziz atifaziz commented Oct 30, 2022 •
edited
Loading

This PR updates to the latest version of coverlet.collector, which seems to restore coverage reporting.

Before this PR, run:

git checkout ac88c7ffdb943c88595bd47d36cf2b07ea941ae6
test.cmd

The coverage report at the end says no assemblies were covered:

Summary
  Generated on: 30/10/2022 - 22:30:30
  Parser: MultiReportParser (4x OpenCoverParser)
  Assemblies: 0
  Classes: 0
  Files: 0
  Line coverage:
  Covered lines: 0
  Uncovered lines: 0
  Coverable lines: 0
  Total lines: 0
No assemblies have been covered.

After applying this PR, the report instead reads:

Summary
  Generated on: 30/10/2022 - 22:44:27
  Parser: MultiReportParser (4x OpenCoverParser)
  Assemblies: 1
  Classes: 15
  Files: 108
  Line coverage: 93.1%
  Covered lines: 3216
  Uncovered lines: 237
  Coverable lines: 3453
  Total lines: 15030

MoreLinq                              93.1%
  Delegating.Delegate                100.0%
  Delegating.DelegatingDisposable     87.5%
  Delegating.DelegatingObserver`1     90.9%
  MoreLinq.Collections.Dictionary`2  100.0%
  MoreLinq.Disposable                  0.0%
  MoreLinq.EmptyArray`1              100.0%
  MoreLinq.Grouping`2                 47.6%
  MoreLinq.ListLike                   92.8%
  MoreLinq.Lookup`2                   62.1%
  MoreLinq.MoreEnumerable             94.8%
  MoreLinq.PendNode`1                 98.4%
  MoreLinq.Reactive.Observable       100.0%
  MoreLinq.Reactive.Subject`1         81.5%
  MoreLinq.ReverseComparer`1         100.0%
  MoreLinq.SequenceException          50.0%

See also:

@atifaziz atifaziz self-assigned this Oct 30, 2022
@codecov
Copy link
codecov bot commented Oct 30, 2022

Codecov Report

Merging #858 (0c95495) into master (ac88c7f) will increase coverage by 92.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #858       +/-   ##
===========================================
+ Coverage        0   92.47%   +92.47%     
===========================================
  Files           0      108      +108     
  Lines           0     3453     +3453     
  Branches        0     1026     +1026     
===========================================
+ Hits            0     3193     +3193     
- Misses          0      197      +197     
- Partials        0       63       +63
Impacted Files Coverage Δ
MoreLinq/Consume.cs 100.00% <0.00%> (ø)
MoreLinq/MoreEnumerable.cs 95.23% <0.00%> (ø)
MoreLinq/Move.cs 96.42% <0.00%> (ø)
MoreLinq/Lag.cs 96.87% <0.00%> (ø)
MoreLinq/ZipLongest.cs 80.95% <0.00%> (ø)
MoreLinq/Collections/Dictionary.cs 100.00% <0.00%> (ø)
MoreLinq/Fold.g.cs 100.00% <0.00%> (ø)
MoreLinq/MinBy.cs 100.00% <0.00%> (ø)
MoreLinq/PendNode.cs 98.48% <0.00%> (ø)
MoreLinq/Exclude.cs 94.73% <0.00%> (ø)
... and 98 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit c16cf64 into morelinq:master Oct 30, 2022
@atifaziz atifaziz deleted the fix-coverage branch October 30, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atifaziz atifaziz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atifaziz
0