Cleanup Partition Nullability
#881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 92.38% 92.58% +0.20%
==========================================
Files 110 108 -2
Lines 3441 3440 -1
Branches 1020 1024 +4
==========================================
+ Hits 3179 3185 +6
+ Misses 200 194 -6
+ Partials 62 61 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atifaziz
requested changes
Nov 15, 2022
There was a problem hiding this comment.
Thanks, but the bulk of changes seem to be unrelated (and I've highlighted a few):
- Formatting changes
- More eager argument validation
- Annotation of some arguments with parameter names.
uses nullable
TKeyvalues in the implementation to more accurately express the code.
This is the only change that should be in here, which is towards the end of Partition.cs.
I would avoid the temptation to bundle unrelated changes as it has the following downsides:
- The diff/patch is larger than it needs to be.
- As a result of the above point, it takes longer to review the PR.
- The PR subject line or the commit message won't reflect the actual change (lost in the noise).
- The final commit won't be atomic so, e.g., if someone wants to revert it in the future, it will undo more work than necessary.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to #803. It uses nullable
TKeyvalues in the implementation to more accurately express the code.