8000 Rename read-only list/collection field of `ListLike`/`CollectionLike` by atifaziz · Pull Request #948 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename read-only list/collection field of ListLike/CollectionLike #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

Rename read-only list/collection field of ListLike/CollectionLike #948

merged 2 commits into from
Jan 27, 2023

Conversation

atifaziz
Copy link
Member

This PR addresses the feedback from @fsateler on PR #472:

rx means read-execute in the unix model. Perhaps _ro for read-only might be better?

@atifaziz atifaziz self-assigned this Jan 27, 2023
@atifaziz atifaziz mentioned this pull request Jan 27, 2023
Merged
@atifaziz atifaziz changed the title Rename read-only list field of ListLike Rename read-only list/collection field of ListLike/CollectionLike Jan 27, 2023
@codecov
Copy link
codecov bot commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #948 (7c3a72f) into master (c8004ac) will not change coverage.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         113      113           
  Lines        3453     3453           
  Branches     1025     1025           
=======================================
  Hits         3192     3192           
  Misses        196      196           
  Partials       65       65
Impacted Files Coverage Δ
MoreLinq/CollectionLike.cs 80.00% <50.00%> (ø)
MoreLinq/ListLike.cs 86.95% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atifaziz atifaziz merged commit 5e2a031 into morelinq:master Jan 27, 2023
@atifaziz atifaziz deleted the list-like-ro-field branch January 27, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsateler fsateler fsateler approved these changes

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees

@atifaziz atifaziz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atifaziz @fsateler @viceroypenguin
0