8000 Remove testing on .NET Core 3.1 that's no longer supported by atifaziz · Pull Request #955 · morelinq/MoreLINQ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove testing on .NET Core 3.1 that's no longer supported #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Remove testing on .NET Core 3.1 that's no longer supported #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef87dd
Remove testing on .NET Core 3.1 that's no longer supported
atifaziz Jan 29, 2023
5efc2a9
Merge branch 'master' into x-netcoreapp3.1
atifaziz Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MoreLinq.Test/MoreLinq.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<AssemblyTitle>MoreLinq.Test</AssemblyTitle>
<TargetFrameworks>net7.0;net6.0;netcoreapp3.1;net462</TargetFrameworks>
<TargetFrameworks>net7.0;net6.0;net462</TargetFrameworks>
<DebugType>portable</DebugType>
10000 <AssemblyName>MoreLinq.Test</AssemblyName>
<OutputType Condition="'$(TargetFramework)' == 'net462'">Exe</OutputType>
Expand Down
6 changes: 0 additions & 6 deletions MoreLinq.Test/NullArgumentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ static IEnumerable<ITestCaseData> GetNotNullTestCases() =>
Debug.Assert(e is not null);
var stackTrace = new StackTrace(e, false);
var stackFrame = stackTrace.GetFrames().First();
#if NETCOREAPP3_1
// Under .NET Core 3.1, "StackTrace.GetFrames()" was defined to return an array
// of nullable frame elements. See:
// https://github.com/dotnet/corefx/blob/v3.1.32/src/Common/src/CoreLib/System/Diagnostics/StackTrace.cs#L162
Debug.Assert(stackFrame is not null);
#endif
var actualType = stackFrame.GetMethod()?.DeclaringType;
Assert.That(actualType, Is.SameAs(typeof(MoreEnumerable)));
});
Expand Down
2 changes: 0 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@ install:
- eclint check -w "**/*.{cs,tt,cmd,sh,md,txt,yml,json,sln,csproj,shfbproj}"
- git reset --hard
- ps: if ($isWindows) { tools\dotnet-install.ps1 -JSonFile global.json }
- ps: if ($isWindows) { tools\dotnet-install.ps1 -Runtime dotnet -Version 3.1.10 -SkipNonVersionedFiles }
- ps: if ($isWindows) { tools\dotnet-install.ps1 -Runtime dotnet -Version 6.0.11 -SkipNonVersionedFiles }
- sh: ./tools/dotnet-install.sh --jsonfile global.json
- sh: ./tools/dotnet-install.sh --runtime dotnet --version 3.1.10 --skip-non-versioned-files
- sh: ./tools/dotnet-install.sh --runtime dotnet --version 6.0.11 --skip-non-versioned-files
- sh: export PATH="$HOME/.dotnet:$PATH"
before_build:
Expand Down
2 changes: 0 additions & 2 deletions test.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ call build ^
&& call :test net7.0 Release ^
&& call :test net6.0 Debug ^
&& call :test net6.0 Release ^
&& call :test netcoreapp3.1 Debug ^
&& call :test netcoreapp3.1 Release ^
&& call :test net462 Debug ^
&& call :test net462 Release ^
&& call :report-cover
Expand Down
2 changes: 1 addition & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if [[ -z "$1" ]]; then
else
configs="$1"
fi
for f in netcoreapp3.1 net6.0 net7.0; do
for f in net6.0 net7.0; do
for c in $configs; do
dotnet test --no-build -c $c -f $f --settings MoreLinq.Test/coverlet.runsettings MoreLinq.Test
TEST_RESULTS_DIR="$(ls -dc MoreLinq.Test/TestResults/* | head -1)"
Expand Down
0