Fix Permutations for when source length is >12
#979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permutations for source length > 12Permutations for when source length is >12
5a96c7e to
20d6798
Compare
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 113 113
Lines 3434 3434
Branches 1052 1054 +2
=======================================
Hits 3180 3180
Misses 191 191
Partials 63 63
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
viceroypenguin
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #978, by using
ulonginternally instead ofintand adding checked arithmetic. This limits to 18,446,744,073,709,551,615 permutations and will overflow thereafter. A document comment has also been added to call out this limitation.Due to the computationally expensive nature of enumerating permutations of a source with more than 12 elements, no unit test has been added to exercise the fix. However, a LINQPad query was used as an eyeball test:
MoreLinqPermutations.zip. At the time of opening this PR, it will use the latest NuGet package version (3.4.0) and exercise the bug. If the package reference is changed to an assembly reference that's the output of this PR, then it will exercise the fix.