8000 docs: document inflation attack (spearbit 40) by MathisGD · Pull Request #592 · morpho-org/morpho-blue · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: document inflation attack (spearbit 40) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2023
Merged

docs: document inflation attack (spearbit 40) #592

merged 6 commits into from
Nov 13, 2023

Conversation

MathisGD
Copy link
Contributor

Rubilmax
Rubilmax requested changes Nov 12, 2023
View reviewed changes
@MathisGD MathisGD requested a review from Rubilmax November 12, 2023 23:54
@MathisGD MathisGD marked this pull request as ready for review November 12, 2023 23:54
MerlinEgalite
MerlinEgalite previously approved these changes Nov 13, 2023
View reviewed changes
Rubilmax
Rubilmax requested changes Nov 13, 2023
View reviewed changes
@MathisGD MathisGD self-assigned this Nov 13, 2023
MerlinEgalite
MerlinEgalite previously approved these changes Nov 13, 2023
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Nov 13, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor
@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a comment explaining that this can be avoiding within the first borrow on the market

@MathisGD MathisGD dismissed stale reviews from Rubilmax and MerlinEgalite via e0a1aa7 November 13, 2023 14:21
@MathisGD @Rubilmax
docs: minor improvement
e0a1aa7 
Co-authored-by: Romain Milon <rmilon@gmail.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD
Copy link
Contributor Author

Maybe we should add a comment explaining that this can be avoiding within the first borrow on the market

To me it's enough like that. Let's keep comments minimal.

@Jean-Grimal
Copy link
Contributor

Maybe we should add a comment explaining that this can be avoiding within the first borrow on the market

To me it's enough like that. Let's keep comments minimal.

Actually you are right, and my point is not true, because as mentioned in #593 the share price might be reset anyway if at some point there is no borrow

@QGarchery
Copy link
Contributor

Maybe we should add a comment explaining that this can be avoiding within the first borrow on the market

To me it's enough like that. Let's keep comments minimal.

Actually you are right, and my point is not true, because as mentioned in #593 the share price might be reset anyway if at some point there is no borrow

Yes and there is no practical way to ensure that the borrow stays on the contract. The usual method of doing a small transaction and forgetting the key does not work, because that small transaction is a borrow and you might get liquidated eventually

@MathisGD @QGarchery
docs: minor improvement
c88ff83 
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MerlinEgalite MerlinEgalite merged commit 06f0f65 into main Nov 13, 2023
@MerlinEgalite MerlinEgalite deleted the docs/document-inflation-attack branch November 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MathisGD @Jean-Grimal @QGarchery @Rubilmax @MerlinEgalite
0