8000 docs(ifc): add edge case by Rubilmax · Pull Request #632 · morpho-org/morpho-blue · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(ifc): add edge case #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2023
Merged

docs(ifc): add edge case #632

merged 4 commits into from
Dec 8, 2023

Conversation

Rubilmax
Copy link
Collaborator
@Rubilmax Rubilmax commented Dec 5, 2023

@Rubilmax Rubilmax marked this pull request as ready for review December 5, 2023 14:17
QGarchery
QGarchery reviewed Dec 5, 2023
View reviewed changes
@Rubilmax @QGarchery
docs(ifc): fix supply -> borrow
4d18f59 
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com>
Signed-off-by: Romain Milon <rmilon@gmail.com>
@Rubilmax Rubilmax linked an issue Dec 7, 2023 that may be closed by this pull request
MorphoBalancesLib.expectedBorrowAssets may return a value greater than totalBorrowAssets #628
Closed
@MathisGD
Copy link
Contributor
MathisGD commented Dec 8, 2023

@Jean-Grimal can you review please

@Rubilmax Rubilmax merged commit ed4f0f4 into post-cantina Dec 8, 2023
@Rubilmax Rubilmax deleted the docs/imorpho branch December 8, 2023 13:29
@MathisGD MathisGD mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@adhusson adhusson Awaiting requested review from adhusson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MorphoBalancesLib.expectedBorrowAssets may return a value greater than totalBorrowAssets
5 participants
@Rubilmax @MathisGD @QGarchery @MerlinEgalite @Jean-Grimal
0