perf(oracle): store price onto stack #113
Conversation
Liquidate was the only function that implied 2 calls to the oracle anyway, am I right ? |
|
The gas diff may not be representative of the true cost savings because of the use of a very basic mock oracle. A real oracle may be much more expensive to call. |
|
Note that if you have custom oracles, they can also take into account that they are called twice (to consume much less gas the second time). |
|
Note also that when the opti of setting address zero as oracle for the quote asset (which I believe happens in a lot of markets) in order for it not to be called, it reduces the gas improvement of this PR. |
|
@MathisGD @QGarchery do you approve? |
There was a problem hiding this comment.
I agree that we want to optimize oracle calls: they can be more complicated, we don't want to add a constraint on them to return early when called twice, and we want to limit external calls (anyone create a market with custom oracles). This PR is a straightforward solution to that problem, but it introduces some duplication.
I'm wondering if there is a different approach, see #137 (not entirely convinced by it yet, it may need more work)
The base branch was changed.
…ho-labs/blue into refactor/oracle-prices
77834bc
|
We can merge @Rubilmax since @QGarchery is not available |
Gas diff is not much per our tests...