8000 Fix compilation by MerlinEgalite · Pull Request #134 · morpho-org/morpho-blue · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix compilation #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2023
Merged

Fix compilation #134

merged 5 commits into from
Jul 18, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Fix #133

@MerlinEgalite MerlinEgalite marked this pull request as ready for review July 16, 2023 15:02
pakim249CAL
pakim249CAL previously approved these changes Jul 16, 2023
View reviewed changes
MathisGD
MathisGD reviewed Jul 16, 2023
View reviewed changes
Rubilmax
Rubilmax reviewed Jul 17, 2023
View reviewed changes
QGarchery
QGarchery reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor
@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding a fix, you are my savior 🙏

Rubilmax
Rubilmax previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator
@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the test suite to use toId would have been a small change & small improvement. This refactoring looks great as is.

makcandrov
makcandrov previously approved these changes Jul 17, 2023
View reviewed changes
QGarchery
QGarchery previously approved these changes Jul 17, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Jul 18, 2023
View reviewed changes
MathisGD
MathisGD previously approved these changes Jul 18, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite mentioned this pull request Jul 18, 2023
Closed
Jean-Grimal
Jean-Grimal previously approved these changes Jul 18, 2023
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Jul 18, 2023
View reviewed changes
@MerlinEgalite MerlinEgalite dismissed stale reviews from Rubilmax and Jean-Grimal via 7802eb8 July 18, 2023 13:17
@MerlinEgalite MerlinEgalite merged commit 28e96a5 into main Jul 18, 2023
@MerlinEgalite MerlinEgalite deleted the fix/calldata-memory-conversion branch July 18, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery QGarchery approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@makcandrov makcandrov makcandrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3FD6 Error when using blue as a dependency
7 participants
@MerlinEgalite @Rubilmax @QGarchery @pakim249CAL @MathisGD @Jean-Grimal @makcandrov
0