MOTECH-1874 Ability to disable task activity audit #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 8, 2016 19:03
fixed warning in recent-task-activity
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
test this please |
| <a class="activity-warn" href="#/tasks/settings">{{msg('task.info.successLogsDisabled')}}</a> | ||
| </td> | ||
| </tr> | ||
| <tr ng-repeat="activity in activities" ng-hide="activities.length == 0"> |
There was a problem hiding this comment.
I think that activities could be in another "tbody". To clarify one tbody will handle all informations and another with activities.
|
test this please |
|
test this please |
|
@kmadej Looks good to me |
|
test this please |
| @@ -65,6 +65,12 @@ | |||
|
|
|||
| private static final String TASK_POSSIBLE_ERRORS_KEY = "task.possible.errors"; | |||
|
|
|||
| @@ -284,8 +293,9 @@ private void handleError(Map<String, Object> params, Task task, TaskHandlerExcep | |||
|
|
|||
| private void handleSuccess(Map<String, Object> params, Task task) { | |||
| LOGGER.debug("All actions from task: {} with ID: {} were successfully executed", task.getName(), task.getId()); | |||
|
|
|||
| activityService.addSuccess(task); | |||
| if (getTaskLogActivities().equals(LOG_ALL_ACTIVITIES)) { | |||
|
After merging https://applab.atlassian.net/browse/MOTECH-2296 ticket we can't disable all task activities. If we don't save them we'll get lost task retrying function and execution many actions in a task. We can miss only failure task activities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added property and option in task settings.