Add Tab for direct departures search #831
Conversation
|
Thank you! This looks like a useful feature! |
|
Fixed the ci issues. :) I'll look into the shadcn tabs! |
|
I've added the shadcn tabs! Also the ci should work now ( |
There was a problem hiding this comment.
Looking good in general, but
- I can't switch to arrivals anymore (error 500, see comment)
- mobile view is slightly destroyed due to fixed width
- on mobile, this further decreases the remaining space for the itinerary results, but I think this is something out of scope of this PR that needs to be improved/changed regardless
- I'm not 100% convinced of the tab name "Fahrplan/Timetable/Horaire". Maybe rather "Verbindungen/Connections/Itinéraires"? But that's just a suggestion.
And yes Docker build always fails on foreign branches. We should fix this but that's not your fault :)
|
Thanks for pointing this out! I thought I fixed the departures/arrivals bug already but apparently not. :D
|
|
If I understand it correctly the problem seems to be that the size was defined through the width of the buttons below the input. Without a fixed width for the card, the departures tab was about 100px wide. |
| @@ -338,28 +291,41 @@ | |||
| <LevelSelect {bounds} {zoom} bind:level /> | |||
|
|
|||
| <div class="maplibregl-control-container"> | |||
| <div class="maplibregl-ctrl-top-left"> | |||
| <div class="maplibregl-ctrl-top-left w-full"> | |||
There was a problem hiding this comment.
Unfortunately this change causes the map to become non-interactive for the whole width of the page for any height range elements are visible on the left:
Hovering anywhere over the highlighted area changes the cursor to default instead of grab and the map cannot be interacted with.
There was a problem hiding this comment.
Thanks for noticing, I've fixed it in #837
I've added a simple layout to search for departures at a single station instead of clicking through the planner.
test.mp4