This repository was archived by the owner on May 4, 2024. It is now read-only.
Add load_function_without_types to VM session and loader
#990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load_function_without_types to session and loader
09d8c1c to
659b43d
8000
Compare
659b43d to
57b6a6e
Compare
load_function_without_types to session and loaderload_function_without_types to VM session and loader
|
I'll re-open this in aptos-core soon once we have the sync working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For Aptos, in order to expose whether a function is a view function in the API-based ABI today, we need to be able to load function metadata through the Aptos VM. The existing function exposed by the Session for this,
load_function, loads information about arguments, generic types, and return types, which is more than is necessary for this use case.To that end I've exposed a version of this function that loads only the module and function, without this additional type information.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Not sure. As far as I can tell,
load_functiondoes not have unit tests either.