8000 Cmakeupdates by sjunges · Pull Request #57 · moves-rwth/carl-storm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cmakeupdates #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Apr 30, 2025
Merged

Cmakeupdates #57

merged 38 commits into from
Apr 30, 2025

Conversation

sjunges
Copy link
Contributor
@sjunges sjunges commented Feb 12, 2025
  • Removed some windows code things
  • Changed include dirs for eigen and gina
  • do not write to cmake_cxx_flags anymore
  • Some other stuff :-)

sjunges and others added 29 commits March 27, 2023 17:26
@sjunges
remove some irrelevant tests
cce6210
@sjunges
typetraits.h specifies it should not be included directly, so lets no…
343df83 
…t do that
@sjunges
updates regarding logging (use a more descriptive ifdef to avoid dupl…
702cb66 
…icates, avoid including carlLogging header if not necessary)
@sjunges
remove cad
12c9bdb
@sjunges
avoid code that cannot compile
8f4a187
@sjunges
fix ordering for polynomials to GrLexOrdering, thereby paving the way…
05ae723 
… to effective forward declarations
@sjunges
version includes patch versions now, update to version 14.24.0
6ee4b6c
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
8320577
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
8f6ed12
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
63d3461
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
8104453
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
b1b5da1
@sjunges
fixes moves-rwth#27
0753294
@sjunges
move ifdef up
deb591d
@sjunges
cmake to project
6b6b9a1
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
d493e43
@sjunges
towards carl for fetchcontent
73e5394
@sjunges
updates
eaaffc7
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm
8ec7070
@sjunges
Merge branch 'master' into cmakeupdates
7cc22f7
@sjunges
updates regarding ginac and what we install
e1f43a2
@sjunges
remove comment
f7c20b8
@volkm
Added carl prefix to more messages
c25b8ac
@sjunges
two fixes based on MVs input
5770375
@sjunges
Merge branch 'cmakeupdates' of https://github.com/sjunges/carl-storm …
056d0e6 
…into cmakeupdates
@sjunges
update
db0230d
@sjunges
Merge branch 'master' of https://github.com/moves-rwth/carl-storm int…
b4367ed 
…o cmakeupdates
@sjunges
updates
8af017f
@sjunges
updates
20346d5
volkm
volkm reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor
@volkm volkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments and clarification questions.

@volkm
Copy link
Contributor
volkm commented Feb 16, 2025

LGTM. Thanks for incorporating the changes.

@sjunges
Copy link
Contributor Author
sjunges commented Mar 29, 2025

Connects to moves-rwth/storm#602

volkm
volkm reviewed Mar 29, 2025
View reviewed changes
@volkm
Copy link
Contributor
volkm commented Mar 29, 2025

LGTM.
Thanks for all your effort!

@volkm volkm mentioned this pull request Apr 7, 2025
Closed
@sjunges sjunges merged commit 8f4f6ff into moves-rwth:master Apr 30, 2025
11 checks passed
@sjunges sjunges deleted the cmakeupdates branch April 30, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volkm volkm volkm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjunges @volkm
0