This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Update flake8 to 3.8.*, and apply new lints #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry will allow any versions with semver specifers to flex during package updates, which is good for libraries that follow semver. Apparently flake8 does not. As well as updating flake8 to a new minor version, this adapts our code to two apparently new lints in flake8 3.8: - `l` is no longer an allowable variable name, because it is ambiguous with I and 1 - f-strings must have placeholders
This was referenced Oct 26, 2020
bors bot
added a commit
that referenced
this pull request
Oct 26, 2020
2279: Update flake8 to 3.8.*, and apply new lints r=rehandalal a=mythmon Poetry will allow any versions with semver specifers to flex during package updates, which is good for libraries that follow semver. Apparently flake8 does not. As well as updating flake8 to a new minor version, this adapts our code to two apparently new lints in flake8 3.8: - `l` is no longer an allowable variable name, because it is ambiguous with I and 1 - f-strings must have placeholders Co-authored-by: Mike Cooper <mythmon@gmail.com>
|
Build failed: |
|
bors retry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a
2E79
subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry will allow any versions with semver specifers to flex during package updates, which is good for libraries that follow semver. Apparently flake8 does not. As well as updating flake8 to a new minor version, this adapts our code to two apparently new lints in flake8 3.8:
lis no longer an allowable variable name, because it is ambiguous with I and 1