kmdc-select (#22) #80
Conversation
There was a problem hiding this comment.
Hi, thanks for the contribution.
I started reviewing it, but noticed that general style and structure of kmdc is not followed very well (understandable as it's poorly documented in the first place). Could you have a look at some of the latest kmdc components and see if you can get a better feel of the architecture of the components (e.g. kmdc-slider). After that, see if you can better refactor you component to match it.
|
I appreciate this might be sucking up more time than you are ready to spare, so I can offer to merge this PR as-is for now and then I'll raise another PR with the remaining polishes for you to review and get a better sense of the general direction kmdc is going for. |
No worries, I have time to work on that, so I'm quite fine proceeding with this MR :) |
There was a problem hiding this comment.
Few minor changes still, but I think after that I'll merge the PR in. I'm still uncertain about some of the new API, but it will have to be refined during the final API review just before 0.1.0 release. To be clear, this is not the only component with uncertain API so far 😆
Closes #22