Misc fixes #703
Merged
Misc fixes #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84e9246 to
17a329a
Compare
fef1be2 to
c4e010a
Compare
base=2**n and base=10 are supported so far. float(), float.fromhex() and MPFR's style (see mpfr_strtofr() function) string formats are accepted. to/from_bstr() undocumented helper functions were removed. Partially taken from mpmath#414. Co-authored-by: Jonathan Warner <warnerjon12@gmail.com>
Co-authored-by: Jonathan Warner <warnerjon12@gmail.com>
This change includes two hypsum related fixes: 1) It turns the ValueError exception, raised in mp.hypsum when encountering convergence problems, into a more appropriate NoConvergence exception - just as fp.hypsum does already. 2) It properly handles this NoConvergence exception withing the "fast path" of hyp2f1. The same behavior is already used in the "fast path"s of _hyp2f0, _hypq1fq, and _hyp_borel - and was broken since hypsum never raised the expected NoConvergence exception (in the mp context). Similar to _hyp2f0, this behavior can be suppressed with the keyword argument force_series=True. Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Coverage tests added.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.