8000 fix-os-lang-package-detection and test code by shihakata · Pull Request #815 · nttcom/threatconnectome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix-os-lang-package-detection and test code #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2025
Merged

fix-os-lang-package-detection and test code #815

merged 5 commits into from
Jul 9, 2025

Conversation

shihakata
Copy link
Collaborator
@shihakata shihakata commented Jul 4, 2025 •
edited
Loading

PR の目的

  • SBOM解析時にOS PackageをLangと誤判定するケースの対策として、SBOMアップロード時のOSpackage判定をpurl.typeで行うように修正
  • purl.typeがOS_TYPEのものと一致するか判定するos_purl_utils.pyを追加
  • また、distroがないOS Packageに関してはecosystemをpurl.typeから取得するように修正

shihakata
shihakata commented Jul 4, 2025
View reviewed changes
@shihakata shihakata force-pushed the topic/fix-os-lang-package-detection branch from 64d1fe5 to 2eb183a Compare July 8, 2025 06:53
@shihakata shihakata marked this pull request as ready for review July 8, 2025 06:56
@shihakata shihakata marked this pull request as draft July 8, 2025 07:46
@shihakata shihakata marked this pull request as ready for review July 8, 2025 08:23
dejima-shikou
dejima-shikou requested changes Jul 8, 2025
View reviewed changes
mshim03
10000
mshim03 previously approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dejima-shikou
dejima-shikou requested changes Jul 9, 2025
View reviewed changes
dejima-shikou
dejima-shikou approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@dejima-shikou dejima-shikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mshim03
mshim03 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator
@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshim03 mshim03 merged commit 63bbf2c into main Jul 9, 2025
5 checks passed
@mshim03 mshim03 deleted the topic/fix-os-lang-package-detection branch July 9, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshim03 mshim03 mshim03 approved these changes

@dejima-shikou dejima-shikou dejima-shikou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shihakata @mshim03 @dejima-shikou
0