8000 [Processor] Propagate allocation metrics by rokatyy · Pull Request #3575 · nuclio/nuclio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Processor] Propagate allocation metrics #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2025
Merged

[Processor] Propagate allocation metrics #3575

merged 5 commits into from
Apr 6, 2025

Conversation

rokatyy
Copy link
Contributor
@rokatyy rokatyy commented Apr 2, 2025

This PR enables the propagation of allocation metrics based on the allocation type.

General Logic:
Async Singleton Allocator: Since an async singleton allocator doesn’t maintain its own metrics, we retrieve allocation metrics from a single object within it.

Sync Pool Allocator: Metrics are directly available, so we return them as is.

Implications:
For any runtime with synchronous event processing, metrics are retrieved from workerAllocator.statistics.

For Python runtime with asynchronous event processing, the flow for retrieving metrics is as follows:

workerAllocator.GetStatistics()  
└── workerAllocator(.asyncSingleton).object.GetAllocatorStatistics()  
    └── worker.GetAllocatorStatistics()  
        └── runtime.connectionManager.allocator.GetAllocatorStatistics()  
            └── connectionAllocator(.syncPool).GetAllocatorStatistics()

@rokatyy rokatyy requested a review from TomerShor April 2, 2025 15:34
rokatyy added 3 commits April 2, 2025 16:36
@rokatyy
Merge remote-tracking branch 'nuclio/development' into nuc-201-metric…
b3439eb 
…s-propagation

# Conflicts:
#	pkg/processor/runtime/rpc/connection/abstract.go
#	pkg/processor/worker/worker.go
@rokatyy
copyrights
ac11d13
@rokatyy
do not need this import
9240195
TomerShor
TomerShor requested changes Apr 3, 2025
View reviewed changes
@TomerShor TomerShor merged commit b702cc3 into nuclio:development Apr 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
runtime/golang runtime/shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokatyy @TomerShor
0