8000 [Controller] Add last k8s warning to an error stack by rokatyy · Pull Request #3625 · nuclio/nuclio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Controller] Add last k8s warning to an error stack #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

[Controller] Add last k8s warning to an error stack #3625

merged 2 commits into from
May 6, 2025

Conversation

rokatyy
Copy link
Contributor
@rokatyy rokatyy commented May 1, 2025 •
edited
Loading

Adds last k8s warning event to an error stack when waiting for a function readiness.
Jira - https://iguazio.atlassian.net/browse/NUC-264

Stack example:


Call stack:
Function available wait is cancelled due to context timeout when function wasn't ready yet. Last k8s events: Last warning event from deployment: Last warning event from one of the function's pods: 0/1 nodes are available: 1 node(s) didn't match Pod's node affinity/selector. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling. 

    .../nuclio/pkg/platform/kube/functionres/lazy.go:348
Failed to wait for function resources to be available
    .../platform/kube/controller/nucliofunction.go:279

@rokatyy rokatyy requested a review from TomerShor May 1, 2025 09:40
TomerShor
TomerShor requested changes May 1, 2025
View reviewed changes
Copy link
Contributor
@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, I have minor comments.

pkg/platform/kube/functionres/lazy.go Outdated

// If no deployment warning, check pods
if podLastEvent := lc.getLastWarningEventForFunctionPods(ctx, function); podLastEvent != "" {
return "Last warning event from one of the function's pods: " + podLastEvent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this message, as it makes the error a bit convoluted (as in the example attached to the description).

@rokatyy rokatyy requested a review from TomerShor May 1, 2025 16:43
@rokatyy rokatyy merged commit 68d2d6f into nuclio:development May 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
platform/kube platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokatyy @TomerShor
0