[Dashboard] Implement elastic search client #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
May 12, 2025
|
|
||
| tlsConfig := &tls.Config{ | ||
| // Set to true to skip TLS verification if SSLVerificationMode is "none" | ||
| InsecureSkipVerify: config.SSLVerificationMode == "none", |
There was a problem hiding this comment.
what are the options for the verification mode? perhaps better to define them as enums/consts
Or, if it is only true / false it can just be a bool
There was a problem hiding this comment.
@TomerShor actually I found only "none" it provazio and it's also a string in provazio, so that's why I kept it the same way
There was a problem hiding this comment.
These are the supported modes.
Need to see how they are translated to the ES client.
There was a problem hiding this comment.
so does certificate require any extra steps from our side?
There was a problem hiding this comment.
@TomerShor yes, but I don't see that we allow to set it from provazio
TomerShor
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds elastic search client to a platform config. Also defines interface for future implementation that is needed for getting logs. Namely, method to return a list of replicas and a method to stream the logs from ES. `
Jira - https://iguazio.atlassian.net/browse/NUC-429