[Controller] Enrich probes during populate deployment container #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Jun 1, 2025
Comment on lines
2507
to
2508
| // enrichment ensures backward compatibility for functions created with controller versions < v1.14.5, where probes may be nil | ||
| common.EnrichProbe(&function.Spec.LivenessProbe, defaultPlatformConfiguration.Kube.DefaultLivenessProbe) |
There was a problem hiding this comment.
avoid duplicating the comment, and do the enrichment for both probes one after the other (meaning, move this to line 2494)
There was a problem hiding this comment.
Fixed here - f433791
rokatyy
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
I agree with @TomerShor comment about moving probes enrichment up to have it togeth 8000 er and only then set the values.
Otherwise, looks good to me!
TomerShor
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Described in the ticket - https://iguazio.atlassian.net/browse/NUC-447
Root Cause
spec.ReadinessProbe).populateDeploymentit tries to reach thespec.ReadinessProbe, which is nilDescription
In this PR, the code changes are basically adding the probes enrichment the same way that were done here.
This enrichment ensures backward compatibility for functions created with controller versions < v1.14.5.
Affected Areas
Nuclio-controller
Testing
Changes Made
Additional Notes
It seems that every controller upgrade triggers an unnecessary CreateOrUpdate call per function.
This doesn't affect running pods, as the final K8s request is ignored when the deployment hasn't changed.
Further investigation is needed.