[CI] Migrate to v2 of golangci #3679
Open
+322
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olangi-cli-bump # Conflicts: # pkg/functionconfig/types.go # pkg/processor/runtime/rpc/result/result.go
TomerShor
requested changes
Jul 3, 2025
.golangci.yml
Outdated
Comment on lines
69
to
71
| - vendor | ||
| - third_party$ | ||
| - builtin$ |
There was a problem hiding this comment.
Are those needed? they're non-existent paths
.golangci.yml
Outdated
Comment on lines
91
to
93
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
| @@ -692,9 +692,9 @@ ensure-test-files-annotated: | |||
| @echo "All go test files have //go:build test_X annotation" | |||
| @exit $(.SHELLSTATUS) | |||
|
|
|||
| GOLANGCI_LINT_VERSION := v1.64.6 | |||
| GOLANGCI_LINT_VERSION := 2.2.0 | |||
There was a problem hiding this comment.
I also noticed some issues with this v.
I suggest also removing it in the the awk command (Line 705):
installed_version=$$($(GOLANGCI_LINT_BIN) version | awk '/version/ {print $$4}' | sed 's/^v//'); \
pkg/functionconfig/handler.go
Outdated
| @@ -36,6 +36,6 @@ func ParseHandler(handler string) (string, string, error) { | |||
| return moduleAndEntrypoint[0], moduleAndEntrypoint[1], nil | |||
|
|
|||
| default: | |||
| return "", "", fmt.Errorf("Invalid handler name %s", handler) | |||
| return "", "", fmt.Errorf("invalid handler name %s", handler) | |||
There was a problem hiding this comment.
Suggested change
| return "", "", fmt.Errorf("invalid handler name %s", handler) | |
| return "", "", errors.Errorf("Invalid handler name %s", handler) |
Comment on lines
-35
to
-36
| # timeout for analysis | ||
| timeout: 5m |
There was a problem hiding this comment.
why is the timeout removed?
There was a problem hiding this comment.
seem to be issue with auto migration, will revert it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to v2 of golangci