8000 [python] Add the choice of the python font size in draw_string() by RedGl0w · Pull Request #1328 · numworks/epsilon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[python] Add the choice of the python font size in draw_string() #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[python] Add the choice of the python font size in draw_string() #1328

wants to merge 4 commits into from

Conversation

RedGl0w
Copy link
Contributor
@RedGl0w RedGl0w commented Feb 20, 2020 •
edited by Ecco
Loading

Demos

draw_string("abc",150,150,color(0,0,0),color(255,255,255),C)

Result with C = 1 or C = True :
unknown

Result without C, with C = 0 or C = False :
unknown (1)

Todo

@RedGl0w RedGl0w requested a review from LeaNumworks February 20, 2020 15:36
@RedGl0w
Added toolbox
652cf7d
@RedGl0w
Revert "Added toolbox"
63b4358 
This reverts commit 652cf7d.

	modifié :         apps/code/catalog.de.i18n
	modifié :         apps/code/catalog.en.i18n
	modifié :         apps/code/catalog.es.i18n
	modifié :         apps/code/catalog.fr.i18n
	modifié :         apps/code/catalog.pt.i18n
	modifié :         apps/code/catalog.universal.i18n
@RedGl0w RedGl0w changed the title Add the choice of the python font size in draw_string() [python] Add the choice of the python font size in draw_string() Feb 25, 2020
@Ecco
Copy link
Contributor
Ecco commented Apr 23, 2020

Hi @RedGl0w ! That's a great suggestion! However using a boolean value makes little sense for the user here. We'd rather use a named constant like in modion.

@RedGl0w
Copy link
Contributor Author
RedGl0w commented Apr 23, 2020

Hi @RedGl0w ! That's a great suggestion! However using a boolean value makes little sense for the user here. We'd rather use a named constant like in modion.

The best solution could be to add in Kandinsky a new type : font
So we could use it everywhere when drawing string, but also for knowing which font is enable (this can be useful for menu in console)

@Ecco
Copy link
Contributor
Ecco commented Apr 23, 2020 •
edited
Loading

knowing which font is enabled (this can be useful for menu in console)

The console isn't handled by Kandinsky at all though… We could consider adding a modsys module, but that's quite out of the scope of this PR.

@RedGl0w
Copy link
Contributor Author
RedGl0w commented Apr 23, 2020

knowing which font is enabled (this can be useful for menu in console)

The console isn't handled by Kandinsky at all though… We could consider adding a modsys module, but that's quite out of the scope of this PR.

I didn't say that the actual font activated should be in kandisnky, I said that the font object should be in kandinsky, because kandinsky is where the fonts are.

@RedGl0w RedGl0w mentioned this pull request Mar 8, 2021
Open
@RedGl0w RedGl0w closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaNumworks LeaNumworks Awaiting requested review from LeaNumworks

Assignees

@artaxxx artaxxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedGl0w @Ecco @artaxxx
0