8000 Manually change the color of functions/sequences by EbbDrop · Pull Request #1385 · numworks/epsilon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Manually change the color of functions/sequences #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6,458 commits into from

Conversation

EbbDrop
Copy link
@EbbDrop EbbDrop commented Mar 6, 2020

Adds a new menu to the function/sequence option-menu to change the color.
Screenshot_from_2020-03-06_01-55-25
Old version see update below!
Fixes #1247 and helps with #931

EmilieNumworks and others added 30 commits February 12, 2020 15:13
…hen there is Unit

The most common case where only the approximate output is displayed
happens when the exact and the approximate outputs are equal, more
precisely when the exact output is equal to the approximate output with
the number of significant digits taken from user settings. That
clarification matters for the Poincare::Integers which have more digits than
the number of significant digits set by the user.

Besides, an Expression containing Units is simplified as
Multiplication(Float, Unit...) recorded identically into the exact and
the approximate outputs (except perhaps the number of significant
digits). Generally, the case where the number of digits in the output is
smaller or equal to the user setting would be matched by the condition,
stated above, that exact and approximate output are equal. But that
should also be the case whatever the number of significant digits. That
is why the presence of Units is matched specifically.
When each Calculation had its own text buffer, the Expression of an
overflowing output text was Undefined. Hence that Expression could have
been Undefined without the corresponding text being 'undef'. That situation
may not happen anymore since Calculation are stored in a shared buffer.
editing

This fixes the following bug: in solver, input Matrix(Matrix()) and select the
inner Matrix. When handling "OK" event, the "=0" is inserted at a wrong
position leading to a crash !
(recursivelyMatches all children is equivalent to recursivelyMatches on
the current node)
…eplaceWithInPlace(B)

Even when A has no parent, B should be detached from its old parent.
Expressions with Units inside an Opposite were beautifed as Undefined
position. This enables to parse "_km_s" as Multiplication(Unit(km),
Unit(s))
didEnterResponderChain behaviours

This fixes the following bug: when editing t
8000
he number of significant
digits, input "1+", click on "OK", the data was reloaded and "1+"
disappeared...
@MixedMatched
Copy link

I would prefer adding a color_view to escher and using gauges as well as presets. That way colors don't have a limited amount. I'll see what I can do later today.

@EbbDrop
Copy link
Author
EbbDrop commented Mar 6, 2020

I will add a custom color option. But I don't think it is necessary to make a color_view just for functions.

@MixedMatched
Copy link

How are you going to show what color something is in the preference menu if you can't show color? Are you just going to say "Custom"? And, if we use a color_view, we can create a row (not a column) of small cells that just have colors instead of a list of colored words.

@EbbDrop
Copy link
Author
EbbDrop commented Mar 6, 2020

Sorry i think i misunderstood you. A color_view seems like a good idee. How would you implement the custom color option?

@EbbDrop
Copy link
Author
EbbDrop commented Mar 6, 2020

Added a nicer color selector by making a color_view:
2020-03-07 18-24-35
It also works with longer names:
2020-03-07 18-25-13

@MixedMatched
Copy link

Wow! That's a very clean implementation. I'm going to see if I can add a clean way for custom colors. If I make one, I'll PR your PR in a few hours.

@nsi-xyz
Copy link
nsi-xyz commented Mar 31, 2020

I love this feature ! Smart and easy to use !

@EbbDrop
Copy link
Author
EbbDrop commented Mar 31, 2020

@cent20net Thanks :)

@artaxxx
Copy link
Collaborator
artaxxx commented Apr 10, 2020

Thanks @EbbDrop , that's interesting :)

I think the list display is better because it's more consistent with the interface of the product. Here are the mockups we worked on to fit the UI:

01
02

@metawops
Copy link
metawops commented Jun 5, 2022

Still no coloring option in Grapher in the current version (18.2.0), right? :-(((

@Yaya-Cout
Copy link
Yaya-Cout commented Jun 5, 2022

It's in the 19.0.0 beta version.

@metawops
Copy link
metawops commented Jun 5, 2022

It's in the 19.0.0 beta version.

Awesome! Unfortunately, can’t install it on my device. Tried several times. Stays at 18.2.0. 🤷‍♂️

@artaxxx
Copy link
Collaborator
artaxxx commented Jun 6, 2022

It's in the 19.0.0 beta version.

Awesome! Unfortunately, can’t install it on my device. Tried several times. Stays at 18.2.0. 🤷‍♂️

The beta version is not available for N0100 models for now

@artaxxx artaxxx closed this Jun 6, 2022
@metawops
Copy link
metawops commented Jun 6, 2022

It's in the 19.0.0 beta version.

Awesome! Unfortunately, can’t install it on my device. Tried several times. Stays at 18.2.0. 🤷‍♂️

The beta version is not available for N0100 models for now

Ahhh, thanks for the hint! It‘s very „unfortunate“ that the process seems to finish successfully, though …
4C7D2456-5F7E-4783-9829-AA87DAEC98C3

So, what other models are there? I, indeed, have a N0100 version … 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually change the color of functions/sequences
0