-
Notifications
You must be signed in to change notification settings - Fork 471
Manually change the color of functions/sequences #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if the text could not be inserted
…hen there is Unit The most common case where only the approximate output is displayed happens when the exact and the approximate outputs are equal, more precisely when the exact output is equal to the approximate output with the number of significant digits taken from user settings. That clarification matters for the Poincare::Integers which have more digits than the number of significant digits set by the user. Besides, an Expression containing Units is simplified as Multiplication(Float, Unit...) recorded identically into the exact and the approximate outputs (except perhaps the number of significant digits). Generally, the case where the number of digits in the output is smaller or equal to the user setting would be matched by the condition, stated above, that exact and approximate output are equal. But that should also be the case whatever the number of significant digits. That is why the presence of Units is matched specifically.
…ayOutput::ApproximateOnly
When each Calculation had its own text buffer, the Expression of an overflowing output text was Undefined. Hence that Expression could have been Undefined without the corresponding text being 'undef'. That situation may not happen anymore since Calculation are stored in a shared buffer.
editing This fixes the following bug: in solver, input Matrix(Matrix()) and select the inner Matrix. When handling "OK" event, the "=0" is inserted at a wrong position leading to a crash !
is 0 or undefined, add tests
involves unit or infinity
(recursivelyMatches all children is equivalent to recursivelyMatches on the current node)
…eplaceWithInPlace(B) Even when A has no parent, B should be detached from its old parent.
Expressions with Units inside an Opposite were beautifed as Undefined
object everytime we need to parse something
position. This enables to parse "_km_s" as Multiplication(Unit(km), Unit(s))
considering parameter as a variable
didEnterResponderChain behaviours This fixes the following bug: when editing t 8000 he number of significant digits, input "1+", click on "OK", the data was reloaded and "1+" disappeared...
I would prefer adding a color_view to escher and using gauges as well as presets. That way colors don't have a limited amount. I'll see what I can do later today. |
I will add a custom color option. But I don't think it is necessary to make a color_view just for functions. |
How are you going to show what color something is in the preference menu if you can't show color? Are you just going to say "Custom"? And, if we use a color_view, we can create a row (not a column) of small cells that just have colors instead of a list of colored words. |
Sorry i think i misunderstood you. A color_view seems like a good idee. How would you implement the custom color option? |
Wow! That's a very clean implementation. I'm going to see if I can add a clean way for custom colors. If I make one, I'll PR your PR in a few hours. |
I love this feature ! Smart and easy to use ! |
@cent20net Thanks :) |
Thanks @EbbDrop , that's interesting :) I think the list display is better because it's more consistent with the interface of the product. Here are the mockups we worked on to fit the UI: |
e385767
to
974bf08
Compare
Still no coloring option in Grapher in the current version (18.2.0), right? :-((( |
It's in the 19.0.0 beta version. |
Awesome! Unfortunately, can’t install it on my device. Tried several times. Stays at 18.2.0. 🤷♂️ |
The beta version is not available for N0100 models for now |
Adds a new menu to the function/sequence option-menu to change the color.

Old version see update below!
Fixes #1247 and helps with #931