feat: add support for live content API #1152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-sanity-module canceled.
|
a174c39 to
0dff794
Compare
|
The conditional |
danielroe
reviewed
Feb 6, 2025
|
Moved to Ready to Review as I think this is ready for input, but will need to investigate why the CI type checks are still failing. |
ce4bf36 to
e0d3fb1
Compare
|
Sorry, I've been out for a while! Just rebased this back onto main and bumped the CI to run node 22 in order to fix this @danielroe Would love to get some advice on this type issue we're seeing, if you have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR adds support for the new Live Content API.
If I've got this one right, I think Nuxt will be a strong contender for the best Sanity Visual Editing experience (when optimistic state lands in another PR). We can maintain the "fastest" path for live updates when in Presentation tool, in addition to having live content in production or when viewing the app in preview mode outside of Presentation. And because Nuxt lets us take care of all the implementation details under the hood, the path for adding this feature for users is still by far the simplest of any framework. In fact adding live content to an existing app should be possible with only a few more lines of configuration.
There is quite a bit of refactoring in this PR as I've tried to move the module away from loading configuration dependent implementations of the same composables. I've tried to avoid breaking changes, assuming we can keep this is a minor release. Input appreciated!