8000 feat(collection): repair SQL query slicing for content larger than 200Kb by elevatebart · Pull Request #3131 · nuxt/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(collection): repair SQL query slicing for content larger than 200Kb #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat(collection): repair SQL query slicing for content larger than 200Kb #3131

farnabaz merged 1 commit into from
Feb 14, 2025

Conversation

elevatebart
Copy link
Contributor
@elevatebart elevatebart commented Feb 14, 2025 •
edited
Loading

🔗 Linked issue

closes #3129

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When running the depoyment of nuxt-content database on D1 on kestra.io we noticed some weird values in the database:

  • Concatenations that should not have been there.
  • Invalid JSON
  • values partly duplicated

Before this PR, the system allowed for queries up to 200Kb to be split in 2.
A query of 300Kb would have also be split in 2 (150 + 150) and fail.

In this PR, the system will run as many updates as needed.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Feb 14, 2025 
npm i https://pkg.pr.new/@nuxt/content@3131

commit: ae79ba7

farnabaz
farnabaz approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member
@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@farnabaz farnabaz merged commit 9d6b6c3 into nuxt:main Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloudflare Server Side Rendering fails on big pages.
2 participants
@elevatebart @farnabaz
0