8000 feat(vite): vite dev server bundler by antfu · Pull Request #604 · nuxt/framework · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite): vite dev server bundler #604

Merged
merged 17 commits into from
Oct 5, 2021
Merged

feat(vite): vite dev server bundler #604

merged 17 commits into from
Oct 5, 2021

Conversation

antfu
Copy link
Member
@antfu antfu commented Sep 30, 2021 •
edited by pi0
Loading

Updates (@pi0):

  • Working playground (dev)
  • Set vite as default bundler
  • Working production build
  • Add time log for perf debug
  • SSR asset hashes
  • Sourcemap support

Backporting nuxt/vite#201

@antfu antfu added the wip label Sep 30, 2021
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Sep 30, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8995009
Status:⚡️  Build in progress...

View logs

@antfu
Copy link
Member Author
antfu commented Sep 30, 2021 •
edited
Loading

Going deeper to it and found this solution does not support circular imports (leading to server hanging). I have fixed the one in app/composables but this could be a serious limitation when it comes to user code and 3rd parties dependencies. I don't see a clear fix to it atm. Do you have any ideas?

@pi0 pi0 mentioned this pull request Sep 30, 2021
Closed
@pi0 pi0 changed the title wip(vite): dev bundler for vite ssr [wip] ferat(vite): implement vite server bundler Oct 2, 2021
@pi0 pi0 changed the title [wip] ferat(vite): implement vite server bundler [wip] feat(vite): implement vite server bundler Oct 2, 2021
@pi0
Copy link
Member
pi0 commented Oct 2, 2021 •
edited
Loading

I've tried to shim vite ssrModue loader implementation which is also considering circular dependencies and seems solved all of the related issues.

Next problem is bundling vue, @vue/reactivity, @vue/shared and vue-router since have no standard ESM build and using cjs causes other issues... fixed by using externals

I Will try to look deeper tomorrow but feel free to push any improvements @antfu :)

@pi0 pi0 assigned pi0 and antfu Oct 2, 2021
@pi0
Copy link
Member
pi0 commented Oct 3, 2021 •
edited
Loading

(updated top description)

@pi0 pi0 changed the title [wip] feat(vite): implement vite server bundler feat(vite): vite dev server bundler Oct 5, 2021
@pi0 pi0 mentioned this pull request Jan 19, 2023
Closed
@pi0 pi0 merged commit bb8c4ff into main Oct 5, 2021
@pi0 pi0 deleted the feat/vite-ssr branch October 5, 2021 14:18
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pi0 pi0

@antfu antfu

Labels
3.x wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfu @pi0 @danielroe
0