8000 feat: Add support for custom provider modifiers in ImageModifiers int… by nathanchase · Pull Request #1844 · nuxt/image · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add support for custom provider modifiers in ImageModifiers int… #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add support for custom provider modifiers in ImageModifiers int… #1844

wants to merge 2 commits into from

Conversation

nathanchase
Copy link
Contributor
@nathanchase nathanchase commented May 16, 2025 •
edited
Loading

🔗 Linked issue

(#1843)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This modifies the ImageModifiers interface to support custom provider modifiers by adding an index signature.

@nathanchase nathanchase requested a review from danielroe as a code owner May 16, 2025 01:05
@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 16, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1844

commit: f9d90c2

@danielroe
Copy link
Member
danielroe commented May 16, 2025 •
edited
Loading

I think instead of this (which removes type safety for modifiers) we should amend useImage to respect the generic provider type.

@nathanchase
Copy link
Contributor Author

Ok, I've updated the PR to preserve type-safety based on the selected provider. Please review and let me know what you think! Thanks, @danielroe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanchase @danielroe
0