fix(icons): update loading icon
#4163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
loading icon
|
I agree the I'm wondering if we should flag this as a breaking change though 🤔 |
benjamincanac
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#4162
❓ Type of change
📚 Description
Currently, we're using the incorrect icon to indicate a loading state. Lucide has icons that are meant to be animated/moved (called "cursors") and both loading-related Lucide icons used in Nuxt UI are not among them. 😅
As a result, these icons (
refresh-cwori-lucide-repeat-2) have always looked sorta... offish. They painfully embody the spirit of a square wagon wheel and in such a beautiful UI library, looks horribly out of place. It got some attention in #2797, which helped but was only a half measure.This PR corrects this UI mistake and puts our best foot forward by replacing all instances with the correct icon, Lucide's
loader-circle. It's designed to be rotationally animated and looks beautiful when doing so.Also, we need to increase effectiveness in explaining how to update test snapshots, so took care of that too: da4ebcd#diff-06ebd47d2ff579d04933c6ada16a9ce1f856852b7056ddada73d8256129f2bfd
Sometimes it's the little things.
CleanShot.2025-05-22.at.16.21.56.mp4
📝 Checklist