fix(components): replace as const with correct type in config
#2652
<
10000
/div>
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandros94
approved these changes
Nov 15, 2024
|
I'm starting to notice this is actually part of a bigger inconsistency in how components are actually typed. For instance the ui/src/runtime/types/divider.d.ts Lines 1 to 3 in d0e626c Personally I would merge this to simply fix the related issue, then in a different PR experiment if it is actually possible to fix all typing. Or is it even worth considering |
sandros94
approved these changes
Nov 16, 2024
as const with correct type in config
as const with correct type in configas const with correct type in config
benjamincanac
approved these changes
Nov 20, 2024
|
@sandros94 I think we can just merge that like you said, it's good enough. All of this hassle is already fixed in |
|
Thanks @gioboa! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2636
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist