8000 fix(module): support `nuxt-nightly` by danielroe · Pull Request #3996 · nuxt/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(module): support nuxt-nightly #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

fix(module): support nuxt-nightly #3996

merged 3 commits into from
Apr 28, 2025

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

spotted when testing with nuxt nightly image - we currently hard-code to nuxt/dist which won't match nuxt-nightly/dist.

I've also switched to knitwork to generate the export as it handles escaping paths. there was also a bug where non-default exports weren't being correctly re-exported

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Apr 27, 2025 
npm i https://pkg.pr.new/@nuxt/ui@3996

commit: 2148f77

@nuxthub-admin NuxtHub Admin
Copy link
Contributor
nuxthub-admin bot commented Apr 27, 2025 •
edited
Loading

✅ Deployed ui3

Deployed ui3 2148f77 to preview

🔗 fix-image-export.ui-6q2.pages.dev
📌 03273e2d.ui-6q2.pages.dev
📱
View QR Code QR code linking to deployment URL.

📋 View deployment logs

@atinux atinux requested a review from benjamincanac April 28, 2025 08:08
@benjamincanac benjamincanac changed the title fix: support nuxt-nightly fix(module): support nuxt-nightly Apr 28, 2025
@benjamincanac benjamincanac merged commit 6366118 into v3 Apr 28, 2025
7 checks passed
@benjamincanac benjamincanac deleted the fix/image-export branch April 28, 2025 08:43
benjamincanac pushed a commit that referenced this pull request Apr 29, 2025
@danielroe @benjamincanac
fix(module): support nuxt-nightly (#3996)
bc0a296
@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @benjamincanac @atinux
0