8000 GenericThings: Fix typo in Generic door/window sensor by mzanetti · Pull Request #468 · nymea/nymea-plugins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

GenericThings: Fix typo in Generic door/window sensor #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mzanetti
Copy link
Contributor
@mzanetti mzanetti commented Aug 13, 2021

nymea-plugins pull request checklist:

  • Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"

  • Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.

  • Did you update the plugin's README.md accordingly?

  • Did you update translations (cd builddir && make lupdate)?

  • If you added a new plugin, should it be added to nymea-plugins-all or nymea-plugins-maker?

@mzanetti mzanetti added the experimental Branches with this tag will be built in the experimental track label Aug 13, 2021
@nymea-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins.nymea.io/job/nymea-plugins-pull-request-tester/1587/

Copy link
Contributor
@t-mon t-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you updated the tranlsations too?

@CLAassistant
Copy link
CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@mzanetti mzanetti changed the base branch from master to add-generic-ev September 2, 2021 12:52
@mzanetti mzanetti force-pushed the fix-generic-door-sensor-typo branch from 8033592 to 989d044 Compare September 2, 2021 12:53
@nymea-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins.nymea.io/job/nymea-plugins-pull-request-tester/1606/

@nymea-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins.nymea.io/job/nymea-plugins-pull-request-tester/1607/

@nymea-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins.nymea.io/job/nymea-plugins-pull-request-tester/1608/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Branches with this tag will be built in the experimental track landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0