8000 Fix: build using CMake Ninja generator and the tests build failure with -DDISABLE_PARCHECK=yes by dnzbk · Pull Request #481 · nzbgetcom/nzbget · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: build using CMake Ninja generator and the tests build failure with -DDISABLE_PARCHECK=yes #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix: build using CMake Ninja generator and the tests build failure with -DDISABLE_PARCHECK=yes #481

merged 1 commit into from
Dec 26, 2024

Conversation

dnzbk
Copy link
Collaborator
@dnzbk dnzbk commented Dec 26, 2024

Description

  • fixed build using CMake Ninja generator
  • fixed tests build failure with -DDISABLE_PARCHECK=yes

Testing

  • Linux Debian 12
  • macOS Ventura

@dnzbk dnzbk requested a review from phnzb December 26, 2024 08:11
This was linked to issues Dec 26, 2024
ninja: error: 'par2-turbo/src/par2-turbo-build/libpar2-turbo.a' #460
Closed
Build fails with -DDISABLE_PARCHECK=yes -DENABLE_TESTS=true (attempts to build ParCheckerTest.cpp and ParRenamerTest.cpp) #480
Closed
@dnzbk dnzbk merged commit a0e2702 into develop Dec 26, 2024
20 checks passed
@dnzbk dnzbk deleted the fix/par2-build branch December 26, 2024 11:45
beertje44 pushed a commit to beertje44/nzbget that referenced this pull request Mar 4, 2025
@dnzbk @beertje44
Fix: build using CMake Ninja generator and the tests build failure wi…
fce9c82 
…th -DDISABLE_PARCHECK=yes (nzbgetcom#481)

- fixed build using CMake Ninja generator
- fixed tests build failure with  -DDISABLE_PARCHECK=yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phnzb phnzb phnzb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dnzbk @phnzb
0