Fix: Correctly decode Unicode escape sequences in JsonDecode #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JsonDecode function in WebUtil incorrectly handled Unicode escape sequences like \u0026. This could lead to malformed data when decoding JSON, particularly URLs containing ampersands passed via the API. This commit modifies the JsonDecode logic to correctly parse \uXXXX sequences into their corresponding characters using strtoul. Unit tests have been added in JsonDecodeTest to verify the fix and cover various standard and Unicode escape sequence scenarios.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JsonDecode function in WebUtil incorrectly handled Unicode escape sequences like \u0026. This could lead to malformed data when decoding JSON, particularly URLs containing ampersands passed via the API.
This commit modifies the JsonDecode logic to correctly parse \uXXXX sequences into their corresponding characters using strtoul.
Lib changes
NA
Testing
Unit tests have been added in JsonDecodeTest to verify the fix and cover various standard and Unicode escape sequence scenarios.