Support writes outside of head partition #23
Conversation
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 63.14% 66.34% +3.21%
==========================================
Files 17 19 +2
Lines 594 909 +315
==========================================
+ Hits 375 603 +228
- Misses 169 215 +46
- Partials 50 91 +41
Continue to review full report at Codecov.
|
|
hi @nakabonne , let me know what you think :) |
|
Thank you @dpgil! I will get back as soon as possible 👍 |
storage_examples_test.go
Outdated
| defer func() { | ||
| if err := storage.Close(); err != nil { | ||
| panic(err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
This is unneeded because the first one will get closed at L623
storage_examples_test.go
Outdated
| defer func() { | ||
| if err := storage.Close(); err != nil { | ||
| panic(err) | ||
| } | ||
| }() |
storage.go
Outdated
| if len(rowsToInsert) == 0 { | ||
| return nil | ||
| } | ||
| if !iterator.next() { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
nit: Currently it's fine, but break makes more sense than the early return. To avoid future confusion, let's use it.
| if len(rowsToInsert) == 0 { | |
| return nil | |
| } | |
| if !iterator.next() { | |
| return nil | |
| } | |
| if len(rowsToInsert) == 0 { | |
| break | |
| } | |
| if !iterator.next() { | |
| break | |
| } |
|
@nakabonne thank you for the feedback! i made the requested changes |
|
Thank you! |
|
v0.2.1 with this change got released. Thank you for your contribution! |
currently we only write to the head partition, this change supports writing to any of the writable partitions (currently set to 2).
ref #20