Add namepsbt RPC method #362
Conversation
This adds a new RPC method, namepsbt. It works in the same way as namerawtransaction to add a name operation to an existing output, but operates on PSBTs rather than hex-format raw transactions.
|
@JeremyRand please take a look if that is what you need. I will merge this in a couple of days if there are no objections. |
|
Concept ACK, will try to review the code shortly (but feel free to merge anyway if I take too long).
@domob1812 Can you elaborate a bit on what workflow would be involved with and without a fix for that upstream issue? I'm under the impression that we'd want a PSBT equivalent of |
|
@JeremyRand Yes, in principle we want So what you can do to work around this is to create the funded transaction without the name input/output (well, I guess you can even include the output if you want) and add a bit of extra fee to it, and then add the name input/output to it with the requested feature. (Note that I only looked into this in the context of |
|
@JeremyRand Any more feedback on this? If not, I will merge it in a couple of days. |
This updates namecoin/namecoin-core#362 for Xaya (mostly for name_register instead of name_new and name_firstupdate).
When namepsbt was added in namecoin#362, the built-in RPC client was not updated and thus failed to correctly convert the "vout" argument to a number and the "nameop" one to a JSON object. Hence, namecoin-cli and the built-in console in the Qt UI were not able to use namepsbt. This fixes the client accordingly.
7c33e3a qt: Add missing mnemonics in menu bar options (Shashwat) Pull request description: Since #362 we have defaulted to add mnemonic shortcuts for the context menus. The Window -> Minimize option and File -> Load PSBT from clipboard were hitherto missing a mnemonic shortcut. This PR adds mnemonic shortcuts for them Changes introduced in this PR: | Master | PR | | ----------| ---- | |  | | ||| ACKs for top commit: jarolrod: tACK 7c33e3a hebasto: ACK 7c33e3a, tested on Linux Mint 20.2 (Qt 5.12.8). Tree-SHA512: 32f201ae7716b19ca123856292f8bfa0d805f6c7271ac1b5e08eff6b95017443754c8a76e8396ccca1869a57384e11016cbd99d63ccdd2fae6da4eaf3ae32298
This adds a new RPC method,
namepsbt. It works in the same way asnamerawtransactionto add a name operation to an existing output, but operates on PSBTs rather than hex-format raw transactions. This fixes #361.With this, it is possible to go through the entire name-trading workflow with just PSBTs and without any hex-format raw transactions. However, it is not yet possible to let the wallet fund the transaction, as that requires funding without the out-of-wallet name input first and only later adding it to the PSBT. Once bitcoin/bitcoin#19608 is implemented, this will be possible as well.