Update docker build links #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the general container registry link redirects to files from 2022. This PR updates to the package location of builds for napari and napri-xpra.
|
Lol, i think the published date is when we started publishing packages. 🤯 |
psobolewskiPhD
approved these changes
May 24, 2025
| Builds are available in the [GitHub Container Registry](https://github.com/orgs/napari/packages). | ||
| Builds are available in the GitHub Container Registry: | ||
| - [napari](https://github.com/napari/napari/pkgs/container/napari) | ||
| - [napari-xpra](https://github.com/napari/napari/pkgs/container/napari-xpra) | ||
|
|
||
| A dockerfile is added to napari root to allow build of a docker image using official napari release. | ||
| It contains two targets built on top of Ubuntu 20.04: |
There was a problem hiding this comment.
Suggested change
| It contains two targets built on top of Ubuntu 20.04: | |
| It contains two targets built on top of the official Python 3.11 slim-bookworm image: |
I'm not sure this is important. Maybe we just delete it so it's not something that needs to be maintained?
Similarly, below it should say:
napari: The result of `python -m pip install pip install "napari[all]", including all the ...
There was a problem hiding this comment.
Yeah, I can go ahead and review the rest of the doc. I just put the PR together when I saw the links 😉
There was a problem hiding this comment.
Updating this is on my todo list 👀 (along with updating the xpra container), so I'd not worry about the whole document. But I just noticed those two lines as being out-dated. We could just remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the general container registry link redirects to files from 2022. This PR updates to the package location of builds for napari and napri-xpra.