[WIP] Deprecate properties in favor of features #5477
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@kevinyamauchi : I picked this up and this is a little easier after merging #5646 Will mark this as ready for review when I think this is in a good place. |
…napari into feat-layer-state-deprecation
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
…napari into feat-layer-state-deprecation
for more information, see https://pre-commit.ci
|
I'm planning to split this XXL PR into two or three parts to help review the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Closes
Closes #3911
Description
This is a joint effort from me and @kevinyamauchi to deprecate the public API around
propertiesstate/parameters across all layers and related utilities, in favor offeatures. We also had to update some implementation details to avoid triggering the deprecation warnings in normal usage of napari.Many of the code changes are in tests. These are mostly updated to maintain behaviors, but use
featuresinstead ofproperties. We also ensured there are some tests to continue to check thatpropertiesare working as expected and also issue deprecation warnings.References
Part of #2866