Add style collection for applying and storing multiple encodings #7 8000 087
+183
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created this because when I looked at #7084 , I thought why are we doing this? Therefore, I'm resurrecting some of the related style encoding work which was one of the motivators of moving to more structured |
|
The next step, which can happen before this gets merged, is to make an equivalent of andy-sweet#6 but with deprecations instead of deletions. Not sure how much time I'm going to have to make that happen, so if anyone is interested in helping, let me know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7087 +/- ##
==========================================
- Coverage 92.95% 92.86% -0.10%
==========================================
Files 618 618
Lines 56486 56558 +72
==========================================
+ Hits 52509 52525 +16
- Misses 3977 4033 +56 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Part of #2866
Description
This adds a utility class for storing a collection of style encodings. The intent is to use this class in a napari layer as a way to replace lots of individual style attributes (e.g.
face_color,face_color_cycle,face_colormap). See andy-sweet#6 to see roughly what this would look like.Credit to @jni for devising this abstraction in andy-sweet#6