[bugfix] update Point size slider on selection (current_size event) # 8000 7137
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7137 +/- ##
==========================================
- Coverage 92.98% 92.88% -0.10%
==========================================
Files 619 619
Lines 56653 56666 +13
==========================================
- Hits 52677 52633 -44
- Misses 3976 4033 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Very nice!
@brisvag i am only guessing but I presume that the last-selected point "wins". Which I think is about as correct as can be. eg programs like Pages will blank out the font selection box when you select text containing multiple fonts — then selecting a font applies it to the whole text — but we don't really have a way to visually indicate this.
This reminds me of the old issue of changing the slider with no points selected — maybe we should think of some visual indicators on the sliders that would show "this applies to the next point" vs "this applies to the current selection" vs "this doesn't represent the current selection but you can drag to set it for the current selection"...
|
@brisvag The size and color shown when selecting multiple points reflect the state of the last previously selected point, so typically the last one placed/moved. |
|
@jni it's this conversation all over again :P |
References and relevant issues
Closes #6115
Description
In this PR i add a connection to the
current_sizeevent, so that the slider is updated for the current size of a selected point.I also add a test for this case.