Layer controls widgets refactor #7355

dalthviz · 2024-11-08T18:48:14Z

References and relevant issues

Related with PR #6219

Description

This takes out some of the refactoring effort proposed over PR #6219 (creation of classes that encapsulate specific widget controls for logic reusage and provide base methods to add those widgets to layer controls classes).

Dependencies/imports diagram related with layer controls

graph LR
	accTitle: Dependencies between modules in the napari Layers controls UI section
	accDescr: Diagram showing the dependencies between the modules involved in the definition of the napari Layers controls UI section
	napari._qt.layer_controls(napari._qt.layer_controls)
	napari._qt.layer_controls --> napari._qt.layer_controls.qt_layer_controls_container
	click napari._qt.layer_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/__init__.py" _blank
	napari._qt.layer_controls.qt_image_controls(napari._qt.layer_controls.qt_image_controls)
	napari._qt.layer_controls.qt_image_controls --> napari._qt.layer_controls.qt_image_controls_base
	napari._qt.layer_controls.qt_image_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_image_controls --> napari._qt.layer_controls.widgets._image
	click napari._qt.layer_controls.qt_image_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_image_controls.py" _blank
	napari._qt.layer_controls.qt_image_controls_base(napari._qt.layer_controls.qt_image_controls_base)
	napari._qt.layer_controls.qt_image_controls_base --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_image_controls_base --> napari._qt.layer_controls.widgets
	click napari._qt.layer_controls.qt_image_controls_base "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_image_controls_base.py" _blank
	napari._qt.layer_controls.qt_labels_controls(napari._qt.layer_controls.qt_labels_controls)
	napari._qt.layer_controls.qt_labels_controls --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_labels_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_labels_controls --> napari._qt.layer_controls.widgets._labels
	click napari._qt.layer_controls.qt_labels_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_labels_controls.py" _blank
	napari._qt.layer_controls.qt_layer_controls_base(napari._qt.layer_controls.qt_layer_controls_base)
	napari._qt.layer_controls.qt_layer_controls_base --> napari._qt.layer_controls.widgets
	click napari._qt.layer_controls.qt_layer_controls_base "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_layer_controls_base.py" _blank
	napari._qt.layer_controls.qt_layer_controls_container(napari._qt.layer_controls.qt_layer_controls_container)
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_image_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_labels_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_points_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_shapes_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_surface_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_tracks_controls
	napari._qt.layer_controls.qt_layer_controls_container --> napari._qt.layer_controls.qt_vectors_controls
	click napari._qt.layer_controls.qt_layer_controls_container "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_layer_controls_container.py" _blank
	napari._qt.layer_controls.qt_points_controls(napari._qt.layer_controls.qt_points_controls)
	napari._qt.layer_controls.qt_points_controls --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_points_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_points_controls --> napari._qt.layer_controls.widgets._points
	click napari._qt.layer_controls.qt_points_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_points_controls.py" _blank
	napari._qt.layer_controls.qt_shapes_controls(napari._qt.layer_controls.qt_shapes_controls)
	napari._qt.layer_controls.qt_shapes_controls --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_shapes_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_shapes_controls --> napari._qt.layer_controls.widgets._shapes
	click napari._qt.layer_controls.qt_shapes_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_shapes_controls.py" _blank
	napari._qt.layer_controls.qt_surface_controls(napari._qt.layer_controls.qt_surface_controls)
	napari._qt.layer_controls.qt_surface_controls --> napari._qt.layer_controls.qt_image_controls_base
	napari._qt.layer_controls.qt_surface_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_surface_controls --> napari._qt.layer_controls.widgets._surface
	click napari._qt.layer_controls.qt_surface_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_surface_controls.py" _blank
	napari._qt.layer_controls.qt_tracks_controls(napari._qt.layer_controls.qt_tracks_controls)
	napari._qt.layer_controls.qt_tracks_controls --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_tracks_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_tracks_controls --> napari._qt.layer_controls.widgets._tracks
	click napari._qt.layer_controls.qt_tracks_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_tracks_controls.py" _blank
	napari._qt.layer_controls.qt_vectors_controls(napari._qt.layer_controls.qt_vectors_controls)
	napari._qt.layer_controls.qt_vectors_controls --> napari._qt.layer_controls.qt_layer_controls_base
	napari._qt.layer_controls.qt_vectors_controls --> napari._qt.layer_controls.widgets
	napari._qt.layer_controls.qt_vectors_controls --> napari._qt.layer_controls.widgets._vectors
	click napari._qt.layer_controls.qt_vectors_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/qt_vectors_controls.py" _blank
	napari._qt.layer_controls.widgets(napari._qt.layer_controls.widgets)
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_autoscale_control
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_colormap_control
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_contrast_limits
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_face_color
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_gamma_slider
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_opacity_blending_controls
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_out_slice_checkbox
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_text_visibility
	napari._qt.layer_controls.widgets --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/__init__.py" _blank
	napari._qt.layer_controls.widgets._image(napari._qt.layer_controls.widgets._image)
	napari._qt.layer_controls.widgets._image --> napari._qt.layer_controls.widgets._image.qt_depiction_control
	napari._qt.layer_controls.widgets._image --> napari._qt.layer_controls.widgets._image.qt_interpolation_combobox
	napari._qt.layer_controls.widgets._image --> napari._qt.layer_controls.widgets._image.qt_render_control
	click napari._qt.layer_controls.widgets._image "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_image/__init__.py" _blank
	napari._qt.layer_controls.widgets._image.qt_depiction_control(napari._qt.layer_controls.widgets._image.qt_depiction_control)
	napari._qt.layer_controls.widgets._image.qt_depiction_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._image.qt_depiction_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_image/qt_depiction_control.py" _blank
	napari._qt.layer_controls.widgets._image.qt_interpolation_combobox(napari._qt.layer_controls.widgets._image.qt_interpolation_combobox)
	napari._qt.layer_controls.widgets._image.qt_interpolation_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._image.qt_interpolation_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_image/qt_interpolation_combobox.py" _blank
	napari._qt.layer_controls.widgets._image.qt_render_control(napari._qt.layer_controls.widgets._image.qt_render_control)
	napari._qt.layer_controls.widgets._image.qt_render_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._image.qt_render_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_image/qt_render_control.py" _blank
	napari._qt.layer_controls.widgets._labels(napari._qt.layer_controls.widgets._labels)
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_brush_size_slider
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_contour_spinbox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_label_color
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox
	napari._qt.layer_controls.widgets._labels --> napari._qt.layer_controls.widgets._labels.qt_render_control
	click napari._qt.layer_controls.widgets._labels "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/__init__.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_brush_size_slider(napari._qt.layer_controls.widgets._labels.qt_brush_size_slider)
	napari._qt.layer_controls.widgets._labels.qt_brush_size_slider --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_brush_size_slider "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_brush_size_slider.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox(napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox)
	napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_color_mode_combobox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox(napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox)
	napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_contiguous_checkbox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_contour_spinbox(napari._qt.layer_controls.widgets._labels.qt_contour_spinbox)
	napari._qt.layer_controls.widgets._labels.qt_contour_spinbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_contour_spinbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_contour_spinbox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox(napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox)
	napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_display_selected_label_checkbox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_label_color(napari._qt.layer_controls.widgets._labels.qt_label_color)
	napari._qt.layer_controls.widgets._labels.qt_label_color --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_label_color "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_label_color.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox(napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox)
	napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_ndim_spinbox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox(napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox)
	napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_preserve_labels_checkbox.py" _blank
	napari._qt.layer_controls.widgets._labels.qt_render_control(napari._qt.layer_controls.widgets._labels.qt_render_control)
	napari._qt.layer_controls.widgets._labels.qt_render_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._labels.qt_render_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_labels/qt_render_control.py" _blank
	napari._qt.layer_controls.widgets._points(napari._qt.layer_controls.widgets._points)
	napari._qt.layer_controls.widgets._points --> napari._qt.layer_controls.widgets._points.qt_border_color
	napari._qt.layer_controls.widgets._points --> napari._qt.layer_controls.widgets._points.qt_current_size_slider
	napari._qt.layer_controls.widgets._points --> napari._qt.layer_controls.widgets._points.qt_symbol_combobox
	click napari._qt.layer_controls.widgets._points "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_points/__init__.py" _blank
	napari._qt.layer_controls.widgets._points.qt_border_color(napari._qt.layer_controls.widgets._points.qt_border_color)
	napari._qt.layer_controls.widgets._points.qt_border_color --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._points.qt_border_color "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_points/qt_border_color.py" _blank
	napari._qt.layer_controls.widgets._points.qt_current_size_slider(napari._qt.layer_controls.widgets._points.qt_current_size_slider)
	napari._qt.layer_controls.widgets._points.qt_current_size_slider --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._points.qt_current_size_slider "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_points/qt_current_size_slider.py" _blank
	napari._qt.layer_controls.widgets._points.qt_symbol_combobox(napari._qt.layer_controls.widgets._points.qt_symbol_combobox)
	napari._qt.layer_controls.widgets._points.qt_symbol_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._points.qt_symbol_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_points/qt_symbol_combobox.py" _blank
	napari._qt.layer_controls.widgets._shapes(napari._qt.layer_controls.widgets._shapes)
	napari._qt.layer_controls.widgets._shapes --> napari._qt.layer_controls.widgets._shapes.qt_edge_color
	napari._qt.layer_controls.widgets._shapes --> napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider
	click napari._qt.layer_controls.widgets._shapes "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_shapes/__init__.py" _blank
	napari._qt.layer_controls.widgets._shapes.qt_edge_color(napari._qt.layer_controls.widgets._shapes.qt_edge_color)
	napari._qt.layer_controls.widgets._shapes.qt_edge_color --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._shapes.qt_edge_color "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_shapes/qt_edge_color.py" _blank
	napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider(napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider)
	napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_shapes/qt_edge_width_slider.py" _blank
	napari._qt.layer_controls.widgets._surface(napari._qt.layer_controls.widgets._surface)
	napari._qt.layer_controls.widgets._surface --> napari._qt.layer_controls.widgets._surface.qt_shading_combobox
	click napari._qt.layer_controls.widgets._surface "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_surface/__init__.py" _blank
	napari._qt.layer_controls.widgets._surface.qt_shading_combobox(napari._qt.layer_controls.widgets._surface.qt_shading_combobox)
	napari._qt.layer_controls.widgets._surface.qt_shading_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._surface.qt_shading_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_surface/qt_shading_combobox.py" _blank
	napari._qt.layer_controls.widgets._tracks(napari._qt.layer_controls.widgets._tracks)
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_colormap_control
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_head_slider
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_id_checkbox
	napari._qt.layer_controls.widgets._tracks --> napari._qt.layer_controls.widgets._tracks.qt_tail_control
	click napari._qt.layer_controls.widgets._tracks "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/__init__.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox(napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox)
	napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_color_properties_combobox.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_colormap_control(napari._qt.layer_controls.widgets._tracks.qt_colormap_control)
	napari._qt.layer_controls.widgets._tracks.qt_colormap_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_colormap_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_colormap_control.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox(napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox)
	napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_graph_checkbox.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_head_slider(napari._qt.layer_controls.widgets._tracks.qt_head_slider)
	napari._qt.layer_controls.widgets._tracks.qt_head_slider --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_head_slider "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_head_slider.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_id_checkbox(napari._qt.layer_controls.widgets._tracks.qt_id_checkbox)
	napari._qt.layer_controls.widgets._tracks.qt_id_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_id_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_id_checkbox.py" _blank
	napari._qt.layer_controls.widgets._tracks.qt_tail_control(napari._qt.layer_controls.widgets._tracks.qt_tail_control)
	napari._qt.layer_controls.widgets._tracks.qt_tail_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._tracks.qt_tail_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_tracks/qt_tail_control.py" _blank
	napari._qt.layer_controls.widgets._vectors(napari._qt.layer_controls.widgets._vectors)
	napari._qt.layer_controls.widgets._vectors --> napari._qt.layer_controls.widgets._vectors.qt_edge_color
	napari._qt.layer_controls.widgets._vectors --> napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox
	napari._qt.layer_controls.widgets._vectors --> napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox
	click napari._qt.layer_controls.widgets._vectors "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_vectors/__init__.py" _blank
	napari._qt.layer_controls.widgets._vectors.qt_edge_color(napari._qt.layer_controls.widgets._vectors.qt_edge_color)
	napari._qt.layer_controls.widgets._vectors.qt_edge_color --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._vectors.qt_edge_color "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_vectors/qt_edge_color.py" _blank
	napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox(napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox)
	napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_vectors/qt_line_dimension_spinbox.py" _blank
	napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox(napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox)
	napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/_vectors/qt_vector_style_combobox.py" _blank
	napari._qt.layer_controls.widgets.qt_autoscale_control(napari._qt.layer_controls.widgets.qt_autoscale_control)
	napari._qt.layer_controls.widgets.qt_autoscale_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_autoscale_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_autoscale_control.py" _blank
	napari._qt.layer_controls.widgets.qt_colormap_control(napari._qt.layer_controls.widgets.qt_colormap_control)
	napari._qt.layer_controls.widgets.qt_colormap_control --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_colormap_control "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_colormap_control.py" _blank
	napari._qt.layer_controls.widgets.qt_contrast_limits(napari._qt.layer_controls.widgets.qt_contrast_limits)
	napari._qt.layer_controls.widgets.qt_contrast_limits --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_contrast_limits "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_contrast_limits.py" _blank
	napari._qt.layer_controls.widgets.qt_face_color(napari._qt.layer_controls.widgets.qt_face_color)
	napari._qt.layer_controls.widgets.qt_face_color --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_face_color "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_face_color.py" _blank
	napari._qt.layer_controls.widgets.qt_gamma_slider(napari._qt.layer_controls.widgets.qt_gamma_slider)
	napari._qt.layer_controls.widgets.qt_gamma_slider --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_gamma_slider "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_gamma_slider.py" _blank
	napari._qt.layer_controls.widgets.qt_opacity_blending_controls(napari._qt.layer_controls.widgets.qt_opacity_blending_controls)
	napari._qt.layer_controls.widgets.qt_opacity_blending_controls --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_opacity_blending_controls "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_opacity_blending_controls.py" _blank
	napari._qt.layer_controls.widgets.qt_out_slice_checkbox(napari._qt.layer_controls.widgets.qt_out_slice_checkbox)
	napari._qt.layer_controls.widgets.qt_out_slice_checkbox --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_out_slice_checkbox "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_out_slice_checkbox.py" _blank
	napari._qt.layer_controls.widgets.qt_text_visibility(napari._qt.layer_controls.widgets.qt_text_visibility)
	napari._qt.layer_controls.widgets.qt_text_visibility --> napari._qt.layer_controls.widgets.qt_widget_controls_base
	click napari._qt.layer_controls.widgets.qt_text_visibility "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_text_visibility.py" _blank
	napari._qt.layer_controls.widgets.qt_widget_controls_base(napari._qt.layer_controls.widgets.qt_widget_controls_base)
	click napari._qt.layer_controls.widgets.qt_widget_controls_base "https://github.com/dalthviz/napari/tree/layer_controls_widgets/napari/_qt/layer_controls/widgets/qt_widget_controls_base.py" _blank
	subgraph module.napari._qt[napari._qt]
		 napari._qt.layer_controls
	end
	class module.napari._qt subgraphs
	subgraph module.napari._qt.layer_controls[napari._qt.layer_controls]
		 napari._qt.layer_controls.qt_image_controls
		 napari._qt.layer_controls.qt_image_controls_base
		 napari._qt.layer_controls.qt_labels_controls
		 napari._qt.layer_controls.qt_layer_controls_base
		 napari._qt.layer_controls.qt_layer_controls_container
		 napari._qt.layer_controls.qt_points_controls
		 napari._qt.layer_controls.qt_shapes_controls
		 napari._qt.layer_controls.qt_surface_controls
		 napari._qt.layer_controls.qt_tracks_controls
		 napari._qt.layer_controls.qt_vectors_controls
		 napari._qt.layer_controls.widgets
	end
	class module.napari._qt.layer_controls subgraphs
	subgraph module.napari._qt.layer_controls.widgets[napari._qt.layer_controls.widgets]
		 napari._qt.layer_controls.widgets._image
		 napari._qt.layer_controls.widgets._labels
		 napari._qt.layer_controls.widgets._points
		 napari._qt.layer_controls.widgets._shapes
		 napari._qt.layer_controls.widgets._surface
		 napari._qt.layer_controls.widgets._tracks
		 napari._qt.layer_controls.widgets._vectors
		 napari._qt.layer_controls.widgets.qt_autoscale_control
		 napari._qt.layer_controls.widgets.qt_colormap_control
		 napari._qt.layer_controls.widgets.qt_contrast_limits
		 napari._qt.layer_controls.widgets.qt_face_color
		 napari._qt.layer_controls.widgets.qt_gamma_slider
		 napari._qt.layer_controls.widgets.qt_opacity_blending_controls
		 napari._qt.layer_controls.widgets.qt_out_slice_checkbox
		 napari._qt.layer_controls.widgets.qt_text_visibility
		 napari._qt.layer_controls.widgets.qt_widget_controls_base
	end
	class module.napari._qt.layer_controls.widgets subgraphs
	subgraph module.napari._qt.layer_controls.widgets._image[napari._qt.layer_controls.widgets._image]
		 napari._qt.layer_controls.widgets._image.qt_depiction_control
		 napari._qt.layer_controls.widgets._image.qt_interpolation_combobox
		 napari._qt.layer_controls.widgets._image.qt_render_control
	end
	class module.napari._qt.layer_controls.widgets._image subgraphs
	subgraph module.napari._qt.layer_controls.widgets._labels[napari._qt.layer_controls.widgets._labels]
		 napari._qt.layer_controls.widgets._labels.qt_brush_size_slider
		 napari._qt.layer_controls.widgets._labels.qt_color_mode_combobox
		 napari._qt.layer_controls.widgets._labels.qt_contiguous_checkbox
		 napari._qt.layer_controls.widgets._labels.qt_contour_spinbox
		 napari._qt.layer_controls.widgets._labels.qt_display_selected_label_checkbox
		 napari._qt.layer_controls.widgets._labels.qt_label_color
		 napari._qt.layer_controls.widgets._labels.qt_ndim_spinbox
		 napari._qt.layer_controls.widgets._labels.qt_preserve_labels_checkbox
		 napari._qt.layer_controls.widgets._labels.qt_render_control
	end
	class module.napari._qt.layer_controls.widgets._labels subgraphs
	subgraph module.napari._qt.layer_controls.widgets._points[napari._qt.layer_controls.widgets._points]
		 napari._qt.layer_controls.widgets._points.qt_border_color
		 napari._qt.layer_controls.widgets._points.qt_current_size_slider
		 napari._qt.layer_controls.widgets._points.qt_symbol_combobox
	end
	class module.napari._qt.layer_controls.widgets._points subgraphs
	subgraph module.napari._qt.layer_controls.widgets._shapes[napari._qt.layer_controls.widgets._shapes]
		 napari._qt.layer_controls.widgets._shapes.qt_edge_color
		 napari._qt.layer_controls.widgets._shapes.qt_edge_width_slider
	end
	class module.napari._qt.layer_controls.widgets._shapes subgraphs
	subgraph module.napari._qt.layer_controls.widgets._surface[napari._qt.layer_controls.widgets._surface]
		 napari._qt.layer_controls.widgets._surface.qt_shading_combobox
	end
	class module.napari._qt.layer_controls.widgets._surface subgraphs
	subgraph module.napari._qt.layer_controls.widgets._tracks[napari._qt.layer_controls.widgets._tracks]
		 napari._qt.layer_controls.widgets._tracks.qt_color_properties_combobox
		 napari._qt.layer_controls.widgets._tracks.qt_colormap_control
		 napari._qt.layer_controls.widgets._tracks.qt_graph_checkbox
		 napari._qt.layer_controls.widgets._tracks.qt_head_slider
		 napari._qt.layer_controls.widgets._tracks.qt_id_checkbox
		 napari._qt.layer_controls.widgets._tracks.qt_tail_control
	end
	class module.napari._qt.layer_controls.widgets._tracks subgraphs
	subgraph module.napari._qt.layer_controls.widgets._vectors[napari._qt.layer_controls.widgets._vectors]
		 napari._qt.layer_controls.widgets._vectors.qt_edge_color
		 napari._qt.layer_controls.widgets._vectors.qt_line_dimension_spinbox
		 napari._qt.layer_controls.widgets._vectors.qt_vector_style_combobox
	end
	class module.napari._qt.layer_controls.widgets._vectors subgraphs
	classDef subgraphs fill:white,strock:black,color:black;	classDef default fill:#00c3ff,color:black;
	linkStyle default stroke:#00c3ff
	classDef external fill:#ffa600,color:black;

Source code directory layout related to layer controls

napari/
└─_qt/
  └─layer_controls/
    ├─qt_image_controls.py
    ├─qt_image_controls_base.py
    ├─qt_labels_controls.py
    ├─qt_layer_controls_base.py
    ├─qt_layer_controls_container.py
    ├─qt_points_controls.py
    ├─qt_shapes_controls.py
    ├─qt_surface_controls.py
    ├─qt_tracks_controls.py
    ├─qt_vectors_controls.py
    ├─widgets/
    │ ├─qt_autoscale_control.py
    │ ├─qt_colormap_control.py
    │ ├─qt_contrast_limits.py
    │ ├─qt_face_color.py
    │ ├─qt_gamma_slider.py
    │ ├─qt_opacity_blending_controls.py
    │ ├─qt_out_slice_checkbox.py
    │ ├─qt_text_visibility.py
    │ ├─qt_widget_controls_base.py
    │ ├─_image/
    │ │ ├─qt_depiction_control.py
    │ │ ├─qt_interpolation_combobox.py
    │ │ ├─qt_render_control.py
    │ │ └─__init__.py
    │ ├─_labels/
    │ │ ├─qt_brush_size_slider.py
    │ │ ├─qt_color_mode_combobox.py
    │ │ ├─qt_contiguous_checkbox.py
    │ │ ├─qt_contour_spinbox.py
    │ │ ├─qt_display_selected_label_checkbox.py
    │ │ ├─qt_label_color.py
    │ │ ├─qt_ndim_spinbox.py
    │ │ ├─qt_preserve_labels_checkbox.py
    │ │ ├─qt_render_control.py
    │ │ └─__init__.py
    │ ├─_points/
    │ │ ├─qt_border_color.py
    │ │ ├─qt_current_size_slider.py
    │ │ ├─qt_symbol_combobox.py
    │ │ └─__init__.py
    │ ├─_shapes/
    │ │ ├─qt_edge_color.py
    │ │ ├─qt_edge_width_slider.py
    │ │ └─__init__.py
    │ ├─_surface/
    │ │ ├─qt_shading_combobox.py
    │ │ └─__init__.py
    │ ├─_tracks/
    │ │ ├─qt_colormap_control.py
    │ │ ├─qt_color_properties_combobox.py
    │ │ ├─qt_graph_checkbox.py
    │ │ ├─qt_head_slider.py
    │ │ ├─qt_id_checkbox.py
    │ │ ├─qt_tail_control.py
    │ │ └─__init__.py
    │ ├─_vectors/
    │ │ ├─qt_edge_color.py
    │ │ ├─qt_line_dimension_spinbox.py
    │ │ ├─qt_vector_style_combobox.py
    │ │ └─__init__.py
    │ └─__init__.py
    └─__init__.py

Notes

~~For the moment,~~ this ~~only~~ covers the shape layer, labels layer, image layer, surface layer and tracks layer controls
There are a couple of widgets definitions that maybe could be further refactored like for example the ones related with the layer colormap attribute (widgets inside qt_colormap_control), the layer rendering attribute (widgets inside qt_render_control) or the layer edge_color/current_edge_color (widgets inside qt_edge_color)
- For the moment the widgets have been moved to the respective layer subfolder
While checking this I noticed a couple of issues:
- Error when using image depiction plane options (IndexError: index -3 is out of bounds for axis 0 with size 2) #7393
- Surface shading combobox control value is not updated when layer shading attribute is modified programatically #7394
Also, noticed that over the Vectors layer controls a raise is being call when handling a TypeError exception (when a edge color mode doesn't correspond with the current valid values). This causes the error to be shown to the user eventhough a fallback to put set a proper value is done. ~~Could it make sense to make an issue about that? 🤔~~
- Created issue to follow up on this: Check if the current behavior on Vectors layers when handling an edge color mode x edge property value selection change from the GUI is correct #7436

codecov · 2024-11-22T15:03:41Z

Codecov Report

Attention: Patch coverage is 97.18805% with 48 lines in your changes missing coverage. Please review.

Project coverage is 93.02%. Comparing base (a930049) to head (eae2741).

Files with missing lines	Patch %	Lines
.../_qt/layer_controls/widgets/qt_colormap_control.py	84.09%	14 Missing ⚠️
...t/layer_controls/widgets/_vectors/qt_edge_color.py	85.88%	12 Missing ⚠️
...t/layer_controls/widgets/_labels/qt_label_color.py	95.69%	4 Missing ⚠️
...controls/widgets/_labels/qt_color_mode_combobox.py	90.90%	3 Missing ⚠️
...r_controls/widgets/_shapes/qt_edge_width_slider.py	91.66%	3 Missing ⚠️
...yer_controls/widgets/_points/qt_symbol_combobox.py	93.75%	2 Missing ⚠️
...i/_qt/layer_controls/widgets/qt_text_visibility.py	93.33%	2 Missing ⚠️
.../layer_controls/widgets/qt_widget_controls_base.py	89.47%	2 Missing ⚠️
...ntrols/widgets/_image/qt_interpolation_combobox.py	97.14%	1 Missing ⚠️
...controls/widgets/_points/qt_current_size_slider.py	97.77%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7355      +/-   ##
==========================================
+ Coverage   92.92%   93.02%   +0.09%     
==========================================
  Files         647      690      +43     
  Lines       60975    61482     +507     
==========================================
+ Hits        56664    57196     +532     
+ Misses       4311     4286      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dalthviz · 2024-11-27T15:53:26Z

Note: Some code clean up and docstrings changes are still needed but marking this as ready for review in case someone wants to give feedback

Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>

jni · 2025-03-03T09:07:28Z

@dalthviz should we pull this out of draft? Thank you for the continuous updates, I know it's not easy!!! 🙏

dalthviz · 2025-03-03T23:10:02Z

Hi @jni! I think there are still a couple of comments to address before this is ready for another review so probably is still better to leave this as a draft. I would say that the three main things to do are:

Manual definition of attributes inside controls classes and removal of logic that auto adds controls as class attributes (Layer controls widgets refactor #7355 (comment))
Classes docstrings updates/simplifications/sorting (Layer controls widgets refactor #7355 (comment))
Change attributes names in the controls classes to always follow PEP-8 conventions/use of underscore instead of camel case (Layer controls widgets refactor #7355 (comment))

Also, I think I will probably have some time over the weekend to work on those things but if someone has time and wants to tackle those right now go ahead :)

…class attritbutes instead

willingc · 2025-03-18T21:48:53Z

Hi @dalthviz, You've put a bunch of work into this PR. No pressure but would you like this to go into 0.6.0. If so, Friday is the release date for 0.6.0a1. If you think it would be better to have in 0.7.0, we can adust the milestone.

@jni fyi

dalthviz · 2025-03-19T03:33:01Z

Hi there @willingc ! I don't think I will have time to do further changes here before Friday so leaving this for 0.7.0 makes sense to me 👍

…napari into layer_controls_widgets

dalthviz added 2 commits September 25, 2024 13:51

Specialized layer control widgets

1e0a2d6

Use specialized widget controls for the Shapes layer controls

5a0a2fd

dalthviz self-assigned this Nov 8, 2024

github-actions bot added the qt Relates to qt label Nov 8, 2024

dalthviz added 2 commits November 8, 2024 13:55

Merge branch 'main' into layer_controls_widgets

f87de9a

Typing

bb3a7df

willingc added needs:discussion Needs further discussion needs:out-of-draft Needs transition from draft to ready for review and removed needs:discussion Needs further discussion labels Nov 10, 2024

dalthviz added 9 commits November 13, 2024 14:35

Merge branch 'main' into layer_controls_widgets

a5cb64c

Use specialized widget controls for the Labels layer controls

610ee27

Typing

e7a8666

Merge branch 'main' into layer_controls_widgets

d98935a

Use specialized widget controls for the Points layer controls

4255244

Typing

9cff6c1

Merge branch 'main' into layer_controls_widgets

0e5f318

Use specialized widget controls for the Image/Surface layer controls

da81fc3

Some code clean up and tests updates

4ded9fc

github-actions bot added the tests Something related to our tests label Nov 21, 2024

dalthviz added 2 commits November 21, 2024 14:16

More code clean up. Add missing layer events disconnection logic

639c064

Merge branch 'main' into layer_controls_widgets

b4a9bed

dalthviz added 4 commits November 25, 2024 11:16

Use specialized widget controls for the Vectors layer controls

e2d72ed

Use specialized widget controls for the Tracks layer controls

1c63e97

Typing

f7dac15

Merge branch 'main' into layer_controls_widgets

f767048

dalthviz changed the title ~~Layer controls widgets refactor~~ [WIP] Layer controls widgets refactor Nov 27, 2024

dalthviz marked this pull request as ready for review November 27, 2024 15:53

dalthviz requested a review from Czaki as a code owner November 27, 2024 15:53

dalthviz and others added 2 commits February 16, 2025 12:18

Merge branch 'main' into layer_controls_widgets

e897541

Apply suggestions from code review

4d591b8

Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>

dalthviz marked this pull request as draft February 17, 2025 03:48

willingc added the needs:out-of-draft Needs transition from draft to ready for review label Feb 17, 2025

More PEP-8 attributes names changes

2a7735c

dalthviz force-pushed the layer_controls_widgets branch from a09639c to 2a7735c Compare February 24, 2025 01:59

Merge branch 'main' into layer_controls_widgets

e50515e

dalthviz force-pushed the layer_controls_widgets branch from bd482ea to e50515e Compare February 24, 2025 03:15

dalthviz added 3 commits March 8, 2025 16:26

Merge branch 'main' into layer_controls_widgets

da736bb

Remove auto addition of control wrappers and create them manually as …

f457fff

…class attritbutes instead

Testing

0041c7c

willingc mentioned this pull request Mar 14, 2025

Review these items for 0.6.0a1 #7701

Closed

6 tasks

willingc modified the milestones: 0.6.0, 0.7.0, 0.6.1 Mar 19, 2025

dalthviz added 5 commits March 22, 2025 22:57

Merge branch 'main' into layer_controls_widgets

0981dc9

Change control widget attributes to follow PEP-8 convention (snake case)

d5c1c2e

Merge branch 'layer_controls_widgets' of https://github.com/dalthviz/…

51b59b6

…napari into layer_controls_widgets

Testing

3e0abdb

Merge branch 'main' into layer_controls_widgets

cfe8959

TimMonko modified the milestones: 0.6.1, 0.6.2 May 13, 2025

TimMonko modified the milestones: 0.6.2, 0.7.0 Jun 16, 2025

Merge branch 'main' into layer_controls_widgets

eae2741

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Layer controls widgets refactor #7355

Layer controls widgets refactor #7355

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Layer controls widgets refactor #7355

Are you sure you want to change the base?

Layer controls widgets refactor #7355

Uh oh!

Conversation

Uh oh!

References and relevant issues

Description

Dependencies/imports diagram related with layer controls

Source code directory layout related to layer controls

Notes

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!