-
-
Notifications
You must be signed in to change notification settings - Fork 446
Add information about launch command to napari info dialog #7897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +/- on this. I think it's mostly going to be noise. But I don't object.
btw what would the output be from the bundle?
@@ -48,7 +48,7 @@ body: | |||
attributes: | |||
label: "\U0001F30E Environment" | |||
description: | | |||
Please provide detailed information regarding your environment. Please paste the output of `napari --info` here or copy the information from the "napari info" dialog in the napari Help menu. | |||
Please provide detailed information regarding your environment. Please paste the information from the "napari info" dialog in the napari Help menu or the output of `napari --info` here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would revert this, though I understand the motivation...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe allow other core dev to provide opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all my comments are suggestions for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like the new order, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this new order. I'm always going to vote GUI-first, coder second for user facing things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(maybe update the below placeholder text, both for a more recent napari, and to show this addition and the recent experimental settings addition)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change this order then we should ensure the GUI provides parity. Right now I think the GUI info doesn't list plugins and I gather this change is related to plugins, so napari --info
is preferred. And I think part of the motivation for this PR was plugin related...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I think the GUI info doesn't list plugins and I gather this change is related to plugins, so
napari --info
is preferred
Is this something we can fix? I actualyl thought plugin info is in GUI, but it does seem not to be!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change this order then we should ensure the GUI provides parity. Right now I think the GUI info doesn't list plugins and I gather this change is related to plugins, so
napari --info
is preferred. And I think part of the motivation for this PR was plugin related...
Let's me check this. Both ways should provide exactly the same information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened PR to fix that #7899
Will test later (by manual edit bundle) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7897 +/- ##
==========================================
+ Coverage 92.92% 92.94% +0.02%
==========================================
Files 641 641
Lines 60615 60619 +4
==========================================
+ Hits 56324 56340 +16
+ Misses 4291 4279 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That's actually very nice! Ok I'm sold. 😊 |
I worry that it will not help on macOS (because of our |
I am 10000% on board with this. While this has some benefit to us for troubleshooting a bug, I think it actually has a bigger use-case for end user support that wouldn't normally land here on Github. For example, a surprising number of users don't close napari for weeks. Then, when I go to troubleshoot things, I ask how they launched napari (often they have multiple installs) and well... they don't know! It was weeks ago! Which of their 12 terminals and 3 jupyter notebooks is a it from? Was it the bundle? This is genuinely the most prominent issue for me when supporting users. It's the 'did you turn it on and off again', except its the 'how did you turn it on, so that we can restart' version. This is the 'how', to the otherwise 'what' of napari --info. |
Is it working for Windows though? I see for example: Edits: Wait, this is where the executable lives. HUH TIL I thought it would be in the environment? Unless I'm accessing the global napari and thats the ENTIRE point of this PR. 😬 so apparently I'm not actually launching from the .venv, but from a global environment, my bad. Edit again, I've done some wild things to my environment. Used to working from home and not the lab. Save me from my mistakes |
Did this file exist on your machine? |
For sure, I've totally messed up my environment out in ways I didn't expect, so this is actually helping me troubleshoot ! |
Okay so here's the lovely situation I found myself in at work with my VSCode ... and goes to the entire point of the PR that this helped me troubleshoot.
So yeah, don't be like me! Every path was very helpful in figuring this out (I've sinced changed my VSCode defaults to be more cohesive huzzah) |
on mac:
Using the CLI to launch and then GUI info:
From ipython:
From an example:
All of those seem ok! |
References and relevant issues
Description
For better understanding of user bug report, add information about how napari was launched.
Sample output, when napari launched from PartSeg
