fix vendored script and trigger workflow on pull_request #7968
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7968 +/- ##
==========================================
+ Coverage 92.89% 92.93% +0.04%
==========================================
Files 643 647 +4
Lines 60688 60838 +150
==========================================
+ Hits 56375 56539 +164
+ Misses 4313 4299 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brisvag
previously approved these changes
May 26, 2025
|
I can't suggest but in the script line 70 also needs path fix. Edit: you can see here https://github.com/napari/napari/blob/main/src/napari/_vendor/darkdetect/__init__.py |
|
I think it worked since the bot closed the PR :) |
psobolewskiPhD
approved these changes
May 26, 2025
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
brisvag
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
extracted from #7966
Description
Fix path in
tools/check_vendored_modules.pyand trigger.github/workflows/test_vendored.ymlon edit related files