8000 build fixes for zig dev 0.14.0-dev.1820+ea527f7a8 by nurpax · Pull Request #105 · natecraddock/ziglua · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build fixes for zig dev 0.14.0-dev.1820+ea527f7a8 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

build fixes for zig dev 0.14.0-dev.1820+ea527f7a8 #105

merged 1 commit into from
Oct 9, 2024

Conversation

nurpax
Copy link
Contributor
@nurpax nurpax commented Oct 8, 2024 •
edited
Loading

Catching up with some latest Zig compiler & build system changes.

Not sure of the include dir change is correct but it's working at least when running zig build test and zig build run-example-interpreter

for #104

@nurpax
Copy link
Contributor Author
nurpax commented Oct 8, 2024

CI won't pass with this change since CI uses 0.13 and this fixes 0.14 dev.

@natecraddock
Copy link
Owner

Thank you for working on this! You are welcome to update the ci in the PR if you want.

I'm unsure of if I want to merge this into main, or if I want this in a dev branch of some kind. I'll give that some thought before merging

@nurpax
Copy link
Contributor Author
nurpax commented Oct 8, 2024 •
edited
Loading

Yeah, better think it through where these devel versions should live. One alternative would be to keep main as the "latest possible zig version" and then a branch per real zig versioned release. IMO this model generally makes it a little easier to know where to work on new stuff as it'll always be main. If main is not the latest version, then what is it? Some kind of release version but which Zig version?

@nurpax nurpax force-pushed the build-fixes-for-zigdev branch from 8e8980c to 7ba377f Compare October 8, 2024 21:23
@nurpax nurpax force-pushed the build-fixes-for-zigdev < 8000 /span> branch from 7ba377f to 2b94535 Compare October 8, 2024 21:23
@nurpax
Copy link
Contributor Author
nurpax commented Oct 8, 2024

You are welcome to update the ci in the PR if you want.

Why didn't I think of that. 😄 I force-pushed an updated commit and it's passing now.

@natecraddock natecraddock linked an issue Oct 9, 2024 that may be closed by this pull request
build.zig not compiling with zig 0.14.0-dev.1820+ea527f7a8 #104
Closed
@natecraddock
Copy link
Owner

Yeah I agree keeping main as following Zig master is a good idea. I'll branch off the commit before this one to make a Zig 0.13.0 branch as needed

@natecraddock natecraddock merged commit b5c9cc5 into natecraddock:main Oct 9, 2024
3 checks passed
@nurpax nurpax deleted the build-fixes-for-zigdev branch February 19, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.zig not compiling with zig 0.14.0-dev.1820+ea527f7a8
2 participants
@nurpax @natecraddock
0